Skip to content

Conversation

@Someone-193
Copy link
Collaborator

Description

Describe the changes
I feel kinda dumb for not checking but honestly this fix was really annoying to research. NW should really refactor their old code, they could probably get more functionality + features for modders if they did so.

What is the current behavior? (You can also link to an open issue here)
see title

What is the new behavior? (if this is a feature change)
its not called twice, nor should it be possible

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:
I think I've handled every sane edge case but if there's any bug in my patch, players can be disconnected just for holstering a consumable so tread carefully when reviewing this.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@Someone-193 Someone-193 merged commit 8ba1b7d into ExMod-Team:dev Jan 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants