BUG: Automatically pass self for server method calls (virtual_text) #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pillzu
changed the title
pillzu
changed the title
This was referenced Apr 23, 2025
Contributor
|
@aliaksandr-trush does this look good? |
|
I didn't mention in the original ticket, but did follow this thread. And I can confirm this resolves the issue. |
aliaksandr-trush
approved these changes
Apr 24, 2025
Contributor
Solution works fine for me. |
|
Works fine for me too. |
|
This also works for me. Finally I got virtual text back Neovim v0.11.0 |
iliadmitriev
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #298
Summary
Function in Lua require
:instead of.to pass self automatically.This PR fixes it by swapping the
.with:as necessary to fix the error.See https://www.lua.org/manual/5.1/manual.html#2.5.8 for more.
Does it work? Yes
Completions now happen successfully (prior behavior can be observed in #298)
