Skip to content

Pass by (const) reference where possible #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marchdf merged 2 commits into from
Oct 28, 2025
Merged

Pass by (const) reference where possible #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fcf1f7
Pass by (const) reference where possible
marchdf Oct 28, 2025
ace30a2
do the interps
marchdf Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
183 changes: 96 additions & 87 deletions src/interp_to_mfab.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,9 @@ int interp_to_mfab::create_height_vector(
// current process
int interp_to_mfab::get_local_height_indices(
amrex::Vector<int>& indvec,
amrex::Vector<amrex::Real> hvec,
amrex::Vector<amrex::MultiFab*> field_fabs,
amrex::Vector<amrex::Geometry> geom)
const amrex::Vector<amrex::Real>& hvec,
const amrex::Vector<amrex::MultiFab*>& field_fabs,
const amrex::Vector<amrex::Geometry>& geom)
{

// Bounds of local AMR mesh
Expand All @@ -122,10 +122,11 @@ int interp_to_mfab::get_local_height_indices(
// current process
int interp_to_mfab::get_local_height_indices(
amrex::Vector<int>& indvec,
amrex::Vector<amrex::Real> hvec,
amrex::Vector<amrex::MultiFab*> field_fabs,
amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>> problo_vec,
amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>> dx_vec)
const amrex::Vector<amrex::Real>& hvec,
const amrex::Vector<amrex::MultiFab*>& field_fabs,
const amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>>&
problo_vec,
const amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>>& dx_vec)
{

// Bounds of local AMR mesh
Expand All @@ -147,10 +148,10 @@ int interp_to_mfab::get_local_height_indices(
// current process
int interp_to_mfab::get_local_height_indices(
amrex::Vector<int>& indvec,
amrex::Vector<amrex::Real> hvec,
amrex::MultiFab& mfab,
amrex::GpuArray<amrex::Real, AMREX_SPACEDIM> problo,
amrex::GpuArray<amrex::Real, AMREX_SPACEDIM> dx)
const amrex::Vector<amrex::Real>& hvec,
const amrex::MultiFab& mfab,
const amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>& problo,
const amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>& dx)
{

// Bounds of local AMR mesh
Expand All @@ -165,9 +166,9 @@ int interp_to_mfab::get_local_height_indices(

// !! -- This assumes cell-centered locations are what matters -- !! //
void interp_to_mfab::get_mfab_mesh_bounds(
amrex::MultiFab& mfab,
amrex::GpuArray<amrex::Real, AMREX_SPACEDIM> problo,
amrex::GpuArray<amrex::Real, AMREX_SPACEDIM> dx,
const amrex::MultiFab& mfab,
const amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>& problo,
const amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>& dx,
amrex::Real& mesh_zlo,
amrex::Real& mesh_zhi,
int idim)
Expand All @@ -185,9 +186,9 @@ void interp_to_mfab::get_mfab_mesh_bounds(

int interp_to_mfab::local_height_vec_ops(
amrex::Vector<int>& indvec,
amrex::Vector<amrex::Real> hvec,
amrex::Real& mesh_zlo,
amrex::Real& mesh_zhi)
const amrex::Vector<amrex::Real>& hvec,
const amrex::Real& mesh_zlo,
const amrex::Real& mesh_zhi)
{
// Loop through height vector and get first and last indices
int itop = -1; // top index is lowest ind, highest height
Expand Down Expand Up @@ -236,8 +237,8 @@ int interp_to_mfab::local_height_vec_ops(
int interp_to_mfab::check_lateral_overlap(
amrex::Real dist,
int idim,
amrex::Vector<amrex::MultiFab*> field_fabs,
amrex::Vector<amrex::Geometry> geom,
const amrex::Vector<amrex::MultiFab*>& field_fabs,
const amrex::Vector<amrex::Geometry>& geom,
bool is_hi)
{

Expand Down Expand Up @@ -279,28 +280,30 @@ int interp_to_mfab::check_lateral_overlap(
int interp_to_mfab::check_lateral_overlap_lo(
amrex::Real dist,
int idim,
amrex::Vector<amrex::MultiFab*> field_fabs,
amrex::Vector<amrex::Geometry> geom)
const amrex::Vector<amrex::MultiFab*>& field_fabs,
const amrex::Vector<amrex::Geometry>& geom)
{
return check_lateral_overlap(dist, idim, field_fabs, geom, false);
}

int interp_to_mfab::check_lateral_overlap_hi(
amrex::Real dist,
int idim,
amrex::Vector<amrex::MultiFab*> field_fabs,
amrex::Vector<amrex::Geometry> geom)
const amrex::Vector<amrex::MultiFab*>& field_fabs,
const amrex::Vector<amrex::Geometry>& geom)
{
return check_lateral_overlap(dist, idim, field_fabs, geom, true);
}

int interp_to_mfab::check_lateral_overlap(
amrex::Real dist,
int idim,
amrex::Vector<amrex::MultiFab*> field_fabs,
amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>> problo_vec,
amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>> probhi_vec,
amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>> dx_vec,
const amrex::Vector<amrex::MultiFab*>& field_fabs,
const amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>>&
problo_vec,
const amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>>&
probhi_vec,
const amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>>& dx_vec,
bool is_hi)
{

Expand Down Expand Up @@ -342,10 +345,12 @@ int interp_to_mfab::check_lateral_overlap(
int interp_to_mfab::check_lateral_overlap_lo(
amrex::Real dist,
int idim,
amrex::Vector<amrex::MultiFab*> field_fabs,
amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>> problo_vec,
amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>> probhi_vec,
amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>> dx_vec)
const amrex::Vector<amrex::MultiFab*>& field_fabs,
const amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>>&
problo_vec,
const amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>>&
probhi_vec,
const amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>>& dx_vec)
{
return check_lateral_overlap(
dist, idim, field_fabs, problo_vec, probhi_vec, dx_vec, false);
Expand All @@ -354,10 +359,12 @@ int interp_to_mfab::check_lateral_overlap_lo(
int interp_to_mfab::check_lateral_overlap_hi(
amrex::Real dist,
int idim,
amrex::Vector<amrex::MultiFab*> field_fabs,
amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>> problo_vec,
amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>> probhi_vec,
amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>> dx_vec)
const amrex::Vector<amrex::MultiFab*>& field_fabs,
const amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>>&
problo_vec,
const amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>>&
probhi_vec,
const amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>>& dx_vec)
{
return check_lateral_overlap(
dist, idim, field_fabs, problo_vec, probhi_vec, dx_vec, true);
Expand All @@ -374,9 +381,9 @@ void interp_to_mfab::interp_eta_to_levelset_field(
const amrex::Real spd_ylo,
const amrex::Real zsl,
const bool is_periodic,
amrex::Gpu::DeviceVector<amrex::Real> etavec,
amrex::Vector<amrex::MultiFab*> lsfield,
amrex::Vector<amrex::Geometry> geom)
const amrex::Gpu::DeviceVector<amrex::Real>& etavec,
const amrex::Vector<amrex::MultiFab*>& lsfield,
const amrex::Vector<amrex::Geometry>& geom)
{

// Number of levels
Expand Down Expand Up @@ -405,10 +412,11 @@ void interp_to_mfab::interp_eta_to_levelset_field(
const amrex::Real spd_ylo,
const amrex::Real zsl,
const bool is_periodic,
amrex::Gpu::DeviceVector<amrex::Real> etavec,
amrex::Vector<amrex::MultiFab*> lsfield,
amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>> problo_vec,
amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>> dx_vec)
const amrex::Gpu::DeviceVector<amrex::Real>& etavec,
const amrex::Vector<amrex::MultiFab*>& lsfield,
const amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>>&
problo_vec,
const amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>>& dx_vec)
{

// Number of levels
Expand All @@ -435,13 +443,13 @@ void interp_to_mfab::interp_velocity_to_field(
const amrex::Real spd_xlo,
const amrex::Real spd_ylo,
const bool is_periodic,
amrex::Vector<int> indvec,
amrex::Vector<amrex::Real> hvec,
amrex::Gpu::DeviceVector<amrex::Real> uvec,
amrex::Gpu::DeviceVector<amrex::Real> vvec,
amrex::Gpu::DeviceVector<amrex::Real> wvec,
amrex::Vector<amrex::MultiFab*> vfield,
amrex::Vector<amrex::Geometry> geom)
const amrex::Vector<int>& indvec,
const amrex::Vector<amrex::Real>& hvec,
const amrex::Gpu::DeviceVector<amrex::Real>& uvec,
const amrex::Gpu::DeviceVector<amrex::Real>& vvec,
const amrex::Gpu::DeviceVector<amrex::Real>& wvec,
const amrex::Vector<amrex::MultiFab*>& vfield,
const amrex::Vector<amrex::Geometry>& geom)
{

// Number of levels
Expand Down Expand Up @@ -485,14 +493,15 @@ void interp_to_mfab::interp_velocity_to_field(
const amrex::Real spd_xlo,
const amrex::Real spd_ylo,
const bool is_periodic,
amrex::Vector<int> indvec,
amrex::Vector<amrex::Real> hvec,
amrex::Gpu::DeviceVector<amrex::Real> uvec,
amrex::Gpu::DeviceVector<amrex::Real> vvec,
amrex::Gpu::DeviceVector<amrex::Real> wvec,
amrex::Vector<amrex::MultiFab*> vfield,
amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>> problo_vec,
amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>> dx_vec)
const amrex::Vector<int>& indvec,
const amrex::Vector<amrex::Real>& hvec,
const amrex::Gpu::DeviceVector<amrex::Real>& uvec,
const amrex::Gpu::DeviceVector<amrex::Real>& vvec,
const amrex::Gpu::DeviceVector<amrex::Real>& wvec,
const amrex::Vector<amrex::MultiFab*>& vfield,
const amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>>&
problo_vec,
const amrex::Vector<amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>>& dx_vec)
{

// Number of levels
Expand Down Expand Up @@ -537,10 +546,10 @@ void interp_to_mfab::interp_eta_to_levelset_multifab(
const amrex::Real spd_ylo,
const amrex::Real zsl,
const bool is_periodic,
amrex::Gpu::DeviceVector<amrex::Real> etavec,
const amrex::Gpu::DeviceVector<amrex::Real>& etavec,
amrex::MultiFab& lsfab,
amrex::GpuArray<amrex::Real, AMREX_SPACEDIM> problo,
amrex::GpuArray<amrex::Real, AMREX_SPACEDIM> dx)
const amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>& problo,
const amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>& dx)
{

if (spd_ny == 1) {
Expand All @@ -563,14 +572,14 @@ void interp_to_mfab::interp_velocity_to_multifab(
const amrex::Real spd_xlo,
const amrex::Real spd_ylo,
const bool is_periodic,
amrex::Vector<int> indvec,
amrex::Vector<amrex::Real> hvec,
amrex::Gpu::DeviceVector<amrex::Real> uvec,
amrex::Gpu::DeviceVector<amrex::Real> vvec,
amrex::Gpu::DeviceVector<amrex::Real> wvec,
const amrex::Vector<int>& indvec,
const amrex::Vector<amrex::Real>& hvec,
const amrex::Gpu::DeviceVector<amrex::Real>& uvec,
const amrex::Gpu::DeviceVector<amrex::Real>& vvec,
const amrex::Gpu::DeviceVector<amrex::Real>& wvec,
amrex::MultiFab& vfab,
amrex::GpuArray<amrex::Real, AMREX_SPACEDIM> problo,
amrex::GpuArray<amrex::Real, AMREX_SPACEDIM> dx)
const amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>& problo,
const amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>& dx)
{

if (spd_ny == 1) {
Expand All @@ -594,10 +603,10 @@ void interp_to_mfab::interp_eta_to_levelset_multifab3D(
const amrex::Real spd_ylo,
const amrex::Real zsl,
const bool is_periodic,
amrex::Gpu::DeviceVector<amrex::Real> etavec,
const amrex::Gpu::DeviceVector<amrex::Real>& etavec,
amrex::MultiFab& lsfab,
amrex::GpuArray<amrex::Real, AMREX_SPACEDIM> problo,
amrex::GpuArray<amrex::Real, AMREX_SPACEDIM> dx)
const amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>& problo,
const amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>& dx)
{

// Get pointer to device vector
Expand Down Expand Up @@ -689,14 +698,14 @@ void interp_to_mfab::interp_velocity_to_multifab3D(
const amrex::Real spd_xlo,
const amrex::Real spd_ylo,
const bool is_periodic,
amrex::Vector<int> indvec,
amrex::Vector<amrex::Real> hvec,
amrex::Gpu::DeviceVector<amrex::Real> uvec,
amrex::Gpu::DeviceVector<amrex::Real> vvec,
amrex::Gpu::DeviceVector<amrex::Real> wvec,
const amrex::Vector<int>& indvec,
const const amrex::Vector<amrex::Real>& hvec,
const amrex::Gpu::DeviceVector<amrex::Real>& uvec,
const amrex::Gpu::DeviceVector<amrex::Real>& vvec,
const amrex::Gpu::DeviceVector<amrex::Real>& wvec,
amrex::MultiFab& vfab,
amrex::GpuArray<amrex::Real, AMREX_SPACEDIM> problo,
amrex::GpuArray<amrex::Real, AMREX_SPACEDIM> dx)
const amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>& problo,
const amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>& dx)
{
// Number of heights relevant to this processor
const int nhts = indvec.size();
Expand Down Expand Up @@ -861,10 +870,10 @@ void interp_to_mfab::interp_eta_to_levelset_multifab2D(
const amrex::Real spd_xlo,
const amrex::Real zsl,
const bool is_periodic,
amrex::Gpu::DeviceVector<amrex::Real> etavec,
const amrex::Gpu::DeviceVector<amrex::Real>& etavec,
amrex::MultiFab& lsfab,
amrex::GpuArray<amrex::Real, AMREX_SPACEDIM> problo,
amrex::GpuArray<amrex::Real, AMREX_SPACEDIM> dx)
const amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>& problo,
const amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>& dx)
{

// Get pointer to device vector
Expand Down Expand Up @@ -922,13 +931,13 @@ void interp_to_mfab::interp_velocity_to_multifab2D(
const amrex::Real spd_dx,
const amrex::Real spd_xlo,
const bool is_periodic,
amrex::Vector<int> indvec,
amrex::Vector<amrex::Real> hvec,
amrex::Gpu::DeviceVector<amrex::Real> uvec,
amrex::Gpu::DeviceVector<amrex::Real> wvec,
const amrex::Vector<int>& indvec,
const const amrex::Vector<amrex::Real>& hvec,
const amrex::Gpu::DeviceVector<amrex::Real>& uvec,
const amrex::Gpu::DeviceVector<amrex::Real>& wvec,
amrex::MultiFab& vfab,
amrex::GpuArray<amrex::Real, AMREX_SPACEDIM> problo,
amrex::GpuArray<amrex::Real, AMREX_SPACEDIM> dx)
const amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>& problo,
const amrex::GpuArray<amrex::Real, AMREX_SPACEDIM>& dx)
{
// Number of heights relevant to this processor
const int nhts = indvec.size();
Expand Down Expand Up @@ -1114,4 +1123,4 @@ AMREX_GPU_HOST_DEVICE amrex::Real interp_to_mfab::linear_interp1D(
const amrex::Real wx_lo = 1.0 - wx_hi;

return (wx_lo * a0 + wx_hi * a1);
}
}
Loading