Free-Atmosphere Damping for ABLForcing #1728
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… drive surface heat flux.
… wind vector damper for use with ABLForcing.
…tuff about calculating surface heat flux from temperature.
mbkuhn
reviewed
Sep 4, 2025
Comment on lines
+105
to
+106
| ifh.ignore( | ||
| std::numeric_limits<std::streamsize>::max(), '\n'); |
There was a problem hiding this comment.
These code lines are here to skip the header line in the data file. This ignore statement needs to be first, prior to the loop.
Comment on lines
+176
to
+177
| ifh.ignore( | ||
| std::numeric_limits<std::streamsize>::max(), '\n'); |
There was a problem hiding this comment.
These code lines are here to skip the header line in the data file. This ignore statement needs to be first, prior to the loop.
| while (ifh >> data_time >> data_value) { | ||
| m_nearsurf_temp_time.push_back(data_time); | ||
| m_nearsurf_temp_value.push_back(data_value); | ||
| ifh.ignore(std::numeric_limits<std::streamsize>::max(), '\n'); |
There was a problem hiding this comment.
This code line is here to skip the header line in the data file. This ignore statement needs to be first, prior to the loop.
| flux = 0.0012 * wspd_mean * (theta_surface - theta_mean); | ||
| break; | ||
| case amr_wind::MOData::ThetaCalcType::NEAR_SURFACE_TEMPERATURE: | ||
| amrex::Print() << "To be implemented..." << std::endl; |
There was a problem hiding this comment.
this print statement is causing the GPU-related checks to fail. No worries for now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added functionality to ABLForcing to damp the free atmosphere wind back toward the geostrophic wind that the ABLForcing converges upon.
Pull request type
Draft
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Additional background
Issue Number: