Open
Conversation
moprak-nrel
requested changes
Jan 28, 2026
| if (!m_is_initialized) { | ||
| return; | ||
| } | ||
| amrex::Print() << "Initializing ABL Boundary Plane IO\n" |
Contributor
There was a problem hiding this comment.
Do we need this print statement? Seems line 360 is already adding output for frozen boundary plane
| "native format."); | ||
| } | ||
|
|
||
| m_in_data.interpolate(time); |
Contributor
There was a problem hiding this comment.
Is this needed for time constant input?
Contributor
Author
There was a problem hiding this comment.
I am not sure. Will check. I just added a basic skeleton which worked.
| m_in_data.interpolate(time); | ||
| } | ||
|
|
||
| void ABLBoundaryPlane::read_frozen_file() |
Contributor
There was a problem hiding this comment.
This whole function is duping what's insider read_file. Can you just have conditional checks insider read_file to avoid a lot of code duplication?
Contributor
Author
There was a problem hiding this comment.
The read_file function checks while reading the data which will cause failure here since we are cheating the code to read same time step twice.
Co-authored-by: prakash <120606615+moprak-nrel@users.noreply.github.com>
Co-authored-by: prakash <120606615+moprak-nrel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For quasi-steady URANS simulations, there is no need to interpolate multiple time planes and a single plane at end of simulation is sufficient. It is also possible to create that plane using the python tools available in AMR-Wind. This PR modifies the boundary plane reading to allow this special pathway.
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running: