remove const cast

No need for this to be non const

Signed-off-by: Rosen Penev <[email protected]>

Author: neheb

src/basicio.cpp

@@ -1042,7 +1042,7 @@ size_t RemoteIo::Impl::populateBlocks(size_t lowBlock, size_t highBlock) {
     if (rcount == 0) {
       throw Error(ErrorCode::kerErrorMessage, "Data By Range is empty. Please check the permission.");
     }
-    auto source = reinterpret_cast<byte*>(const_cast<char*>(data.c_str()));
+    auto source = reinterpret_cast<const byte*>(data.c_str());
     size_t remain = rcount;
     size_t totalRead = 0;
     size_t iBlock = (rcount == size_) ? 0 : lowBlock;
@@ -1078,7 +1078,7 @@ int RemoteIo::open() {
       p_->size_ = data.length();
       size_t nBlocks = (p_->size_ + p_->blockSize_ - 1) / p_->blockSize_;
       p_->blocksMap_ = std::make_unique<BlockMap[]>(nBlocks);
-      auto source = reinterpret_cast<byte*>(const_cast<char*>(data.c_str()));
+      auto source = reinterpret_cast<const byte*>(data.c_str());
       size_t remain = p_->size_;
       size_t iBlock = 0;
       size_t totalRead = 0;

src/crwimage_int.cpp

@@ -472,18 +472,18 @@ CiffComponent* CiffHeader::findComponent(uint16_t crwTagId, uint16_t crwDir) con
   return pRootDir_->findComponent(crwTagId, crwDir);
 }  // CiffHeader::findComponent
 
-CiffComponent* CiffComponent::findComponent(uint16_t crwTagId, uint16_t crwDir) const {
+CiffComponent* CiffComponent::findComponent(uint16_t crwTagId, uint16_t crwDir) {
   return doFindComponent(crwTagId, crwDir);
 }  // CiffComponent::findComponent
 
-CiffComponent* CiffComponent::doFindComponent(uint16_t crwTagId, uint16_t crwDir) const {
+CiffComponent* CiffComponent::doFindComponent(uint16_t crwTagId, uint16_t crwDir) {
   if (tagId() == crwTagId && dir() == crwDir) {
-    return const_cast<CiffComponent*>(this);
+    return this;
   }
   return nullptr;
 }  // CiffComponent::doFindComponent
 
-CiffComponent* CiffDirectory::doFindComponent(uint16_t crwTagId, uint16_t crwDir) const {
+CiffComponent* CiffDirectory::doFindComponent(uint16_t crwTagId, uint16_t crwDir) {
   for (auto&& component : components_) {
     if (auto cc = component->findComponent(crwTagId, crwDir))
       return cc;

src/crwimage_int.hpp

@@ -228,7 +228,7 @@ class CiffComponent {
     @brief Finds \em crwTagId in directory \em crwDir, returning a pointer to
            the component or 0 if not found.
    */
-  [[nodiscard]] CiffComponent* findComponent(uint16_t crwTagId, uint16_t crwDir) const;
+  [[nodiscard]] CiffComponent* findComponent(uint16_t crwTagId, uint16_t crwDir);
   //@}
 
  protected:
@@ -263,7 +263,7 @@ class CiffComponent {
   //! Implements empty(). Default implementation returns true if size is 0.
   [[nodiscard]] virtual bool doEmpty() const;
   //! Implements findComponent(). The default implementation checks the entry.
-  [[nodiscard]] virtual CiffComponent* doFindComponent(uint16_t crwTagId, uint16_t crwDir) const;
+  [[nodiscard]] virtual CiffComponent* doFindComponent(uint16_t crwTagId, uint16_t crwDir);
   //@}
 
  private:
@@ -360,7 +360,7 @@ class CiffDirectory : public CiffComponent {
   [[nodiscard]] bool doEmpty() const override;
 
   // See base class comment
-  [[nodiscard]] CiffComponent* doFindComponent(uint16_t crwTagId, uint16_t crwDir) const override;
+  [[nodiscard]] CiffComponent* doFindComponent(uint16_t crwTagId, uint16_t crwDir) override;
   //@}
 
   // DATA