use const ref for updateDirEntry

Simpler.

Signed-off-by: Rosen Penev <[email protected]>

Author: neheb

src/tiffvisitor_int.cpp

@@ -582,12 +582,12 @@ void TiffEncoder::visitDirectoryNext(TiffDirectory* object) {
   // Update type and count in IFD entries, in case they changed
   byte* p = object->start() + 2;
   for (const auto& component : object->components_) {
-    p += updateDirEntry(p, byteOrder(), component.get());
+    p += updateDirEntry(p, byteOrder(), component);
   }
 }
 
-uint32_t TiffEncoder::updateDirEntry(byte* buf, ByteOrder byteOrder, TiffComponent* pTiffComponent) {
-  auto pTiffEntry = dynamic_cast<const TiffEntryBase*>(pTiffComponent);
+uint32_t TiffEncoder::updateDirEntry(byte* buf, ByteOrder byteOrder, const TiffComponent::UniquePtr& tiffComponent) {
+  auto pTiffEntry = dynamic_cast<const TiffEntryBase*>(tiffComponent.get());
   if (!pTiffEntry)
     return 0;
   us2Data(buf + 2, pTiffEntry->tiffType(), byteOrder);

src/tiffvisitor_int.hpp

@@ -495,7 +495,7 @@ class TiffEncoder : public TiffVisitor {
            entries are encoded. It takes care of type and count changes
            and size shrinkage for non-intrusive writing.
    */
-  static uint32_t updateDirEntry(byte* buf, ByteOrder byteOrder, TiffComponent* pTiffComponent);
+  static uint32_t updateDirEntry(byte* buf, ByteOrder byteOrder, const TiffComponent::UniquePtr& tiffComponent);
   /*!
     @brief Check if the tag is an image tag of an existing image. Such
            tags are copied from the original image and can't be modified.