fs::path conversions #3074
Merged
fs::path conversions #3074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neheb
force-pushed
the
1
branch
4 times, most recently
from
8caa5a8 to
8316148
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3074 +/- ##
==========================================
- Coverage 64.61% 64.61% -0.01%
==========================================
Files 104 104
Lines 22252 22250 -2
Branches 10923 10923
==========================================
- Hits 14379 14377 -2
Misses 5628 5628
Partials 2245 2245 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
neheb
force-pushed
the
1
branch
3 times, most recently
from
dabf3c0 to
d7d0d3d
Compare
Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
No need for them. Also rewrite some functions to use ifstream instead of fopen. Signed-off-by: Rosen Penev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to reduce fopen calls and overall string/wstring conversions.