Skip to content

Fix 3080 #3081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmilos merged 2 commits into from
Dec 5, 2024
Merged

Fix 3080 #3081

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26cd6e4
DateValue::toRational returns zero if out of range
jim-easterbrook Dec 4, 2024
da83328
Set 'ok_' to false if timestamp overflow error
jim-easterbrook Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/value.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,6 +863,7 @@ int64_t DateValue::toInt64(size_t /*n*/) const {
uint32_t DateValue::toUint32(size_t /*n*/) const {
const int64_t t = toInt64();
if (t < 0 || t > std::numeric_limits<uint32_t>::max()) {
ok_ = false;
return 0;
}
return static_cast<uint32_t>(t);
Expand All @@ -873,7 +874,12 @@ float DateValue::toFloat(size_t n) const {
}

Rational DateValue::toRational(size_t n) const {
return {static_cast<int32_t>(toInt64(n)), 1};
const int64_t t = toInt64(n);
if (t < std::numeric_limits<int32_t>::min() || t > std::numeric_limits<int32_t>::max()) {
ok_ = false;
return {0, 1};
}
return {static_cast<int32_t>(t), 1};
}

TimeValue::TimeValue() : Value(time) {
Expand Down
Loading