Skip to content

fix compilation with C++23 #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kmilos merged 1 commit into from
Jan 10, 2025
Merged

fix compilation with C++23 #3113

kmilos merged 1 commit into from
Jan 10, 2025

Conversation

@neheb
Copy link
Collaborator

@neheb neheb commented Jan 10, 2025

Missing header.

@neheb
fix compilation with C++23
7ed4e9f 
Missing header.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@kmilos
Copy link
Collaborator

kmilos commented Jan 10, 2025 •
edited
Loading

Actually, was this tested? Is <version> included somewhere early for this macro?

kmilos
kmilos reviewed Jan 10, 2025
View reviewed changes
@neheb
Copy link
Collaborator Author

neheb commented Jan 10, 2025

Actually, was this tested? Is <version> included somewhere early for this macro?

yes

@kmilos kmilos merged commit 710f8e6 into Exiv2:main Jan 10, 2025
58 of 59 checks passed
@kmilos
Copy link
Collaborator

kmilos commented Jan 10, 2025

Ok, let's keep the same pattern as in image.cpp.

@neheb neheb deleted the 3 branch January 10, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmilos kmilos kmilos approved these changes

@kevinbackhouse kevinbackhouse kevinbackhouse approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neheb @kmilos @kevinbackhouse