CI: drop fmt dependency on macOS and MSYS2#3133
Merged
Conversation
kmilos
force-pushed
the
kmilos/ci_drop_fmt
branch
from
8415016 to
184a610
Compare
Collaborator
Author
|
Hm, looks like in CMake we check for Any preference in how to handle this @neheb - just swap the order, or add another dedicated |
Collaborator
|
Swap. It becomes alphabetical anyway. |
Collaborator
Author
|
Not it, So this is a macOS/Xcode only thing, I understood it should be supported since XCode 15... |
Collaborator
Author
|
Ok, looks like it's not supported by libc++ for the "default" macOS 13 target (might have to bump to 13.3 somehow?), while it is ok for macOS 14... Edit: libc++ in Xcode 15.3 onwards, which is not available on macOS 13 runners... For now, let's just leave it installed in workflows using macOS 13. |
kmilos
force-pushed
the
kmilos/ci_drop_fmt
branch
2 times, most recently
from
73865e2 to
a9933aa
Compare
kmilos
force-pushed
the
kmilos/ci_drop_fmt
branch
from
a9933aa to
c85c3aa
Compare
neheb
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer needed as C++20 is now used and these platforms ship toolchains w/
std::format.