Merged
Conversation
kmilos
reviewed
Feb 9, 2025
b51fa43 to
193ecdf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3157 +/- ##
==========================================
- Coverage 64.18% 64.01% -0.18%
==========================================
Files 104 104
Lines 22126 21838 -288
Branches 10832 10694 -138
==========================================
- Hits 14202 13980 -222
+ Misses 5708 5644 -64
+ Partials 2216 2214 -2 ☔ View full report in Codecov by Sentry. |
21c3f1e to
5ebe59e
Compare
Looks like they're slow under Cygwin. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
kmilos
reviewed
Feb 17, 2025
kmilos
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like they're slow under Cygwin.
Maybe fixes #3153