Skip to content

remove some ostringstreams#3157

Merged
neheb merged 2 commits intoExiv2:mainfrom
neheb:un
Feb 17, 2025
Merged

remove some ostringstreams#3157
neheb merged 2 commits intoExiv2:mainfrom
neheb:un

Conversation

@neheb
Copy link
Collaborator

@neheb neheb commented Feb 9, 2025

Looks like they're slow under Cygwin.

Maybe fixes #3153

@neheb neheb force-pushed the un branch 6 times, most recently from b51fa43 to 193ecdf Compare February 10, 2025 21:33
@neheb neheb marked this pull request as ready for review February 11, 2025 03:25
@neheb neheb requested a review from kmilos February 15, 2025 20:35
@codecov
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 58.98876% with 73 lines in your changes missing coverage. Please review.

Project coverage is 64.01%. Comparing base (ef6aa48) to head (d8bc93d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/nikonmn_int.cpp 43.75% 18 Missing and 9 partials ⚠️
src/properties.cpp 0.00% 10 Missing ⚠️
src/convert.cpp 70.83% 7 Missing ⚠️
src/pngchunk_int.cpp 0.00% 6 Missing ⚠️
src/samsungmn_int.cpp 0.00% 4 Missing ⚠️
src/casiomn_int.cpp 0.00% 3 Missing ⚠️
src/datasets.cpp 76.92% 2 Missing and 1 partial ⚠️
src/panasonicmn_int.cpp 40.00% 3 Missing ⚠️
include/exiv2/value.hpp 50.00% 0 Missing and 2 partials ⚠️
src/canonmn_int.cpp 89.47% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3157      +/-   ##
==========================================
- Coverage   64.18%   64.01%   -0.18%     
==========================================
  Files         104      104              
  Lines       22126    21838     -288     
  Branches    10832    10694     -138     
==========================================
- Hits        14202    13980     -222     
+ Misses       5708     5644      -64     
+ Partials     2216     2214       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neheb neheb force-pushed the un branch 3 times, most recently from 21c3f1e to 5ebe59e Compare February 16, 2025 23:52
Looks like they're slow under Cygwin.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb neheb merged commit 2b74972 into Exiv2:main Feb 17, 2025
60 checks passed
@neheb neheb deleted the un branch February 17, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExifKey::Impl::tagName() is Slow

2 participants