-
Notifications
You must be signed in to change notification settings - Fork 309
Rename to allow all exiv2 tags as placeholders (backport #2791) #3364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Cherry-pick of d31fff2 has failed: Cherry-pick of eea87bf has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
optimise regex and remove duplicate call of ImageFactory
optimise regex and remove duplicate call of ImageFactory
tests adjusted for msys and cygwin; regex contains "Exif" for better filtering; documentation adjusted
for concatenation of new file name, concatenation operator of std::filesystem::path is not used: On MSYS2 UCRT64 the path separator to be used in terminal is slash, but as concatenation operator a back slash will be added. Rename works but with verbose a path with different operators will be shown.
4d12cb9 to
ba9ce00
Compare
|
@norbertwg Any ideas why this is not working (test fails) on the 0.28.x branch? |
|
NVM, think I found the missing backport piece... @kevinbackhouse Please feel free to squash the last commits. |
closes #2238
This is an automatic backport of pull request #2791 done by [Mergify](https://mergify.com).