Support setting http headers when using CurlIO#3431
Open
nkming2 wants to merge 2 commits intoExiv2:mainfrom
Open
Support setting http headers when using CurlIO#3431nkming2 wants to merge 2 commits intoExiv2:mainfrom
nkming2 wants to merge 2 commits intoExiv2:mainfrom
Conversation
Collaborator
|
This change looks fine to me, but please could you add a test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the ability to set custom HTTP headers when reading HTTP files using curl. This will allow exiv2 to handle remote files that require HTTP authentication to access. The current workaround is to download the whole file locally which is very inefficient.