Conversation
kevinbackhouse
previously approved these changes
Feb 9, 2026
Collaborator
Author
|
@kevinbackhouse More tests keep failing on mac, I guess either gtest or LLVM/Xcode got updated there and are more strict... Have we fixed all of these on main already? |
Collaborator
|
On main, we have some tests that frequently fail, but they usually pass after one or two retries. I haven't investigated yet to see what the differences are. |
Collaborator
Author
That could be #3459 I think this is different. Will have to dig into differences between the two setups indeed... |
Signed-off-by: Rosen Penev <rosenp@gmail.com> (cherry picked from commit 8414a98)
kmilos
force-pushed
the
kmilos-patch-1
branch
from
7a69466 to
4b048a1
Compare
mergify
bot
dismissed
kevinbackhouse’s stale review
Pull request has been modified.
Collaborator
Author
|
Back down to the one "known" failure. |
kevinbackhouse
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macos-13 (Intel) has been deprecated since, macos-15-intel is the only available option.