Skip to content

fix: grant camera permission based on origin #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mzndako merged 4 commits into from
Feb 21, 2025
Merged

fix: grant camera permission based on origin #36

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8884854
fix: grant camera permision base on origin for ios
mzndako Feb 20, 2025
948b911
fix: remove unused function
mzndako Feb 20, 2025
2598a37
fix: grant camera permission base on origin for android
mzndako Feb 20, 2025
8350bbf
fix: use getHost to construct the origin
mzndako Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,14 +226,14 @@ private String getLackPermissionToDownloadMessage() {
return mDownloadingMessage == null ? DEFAULT_LACK_PERMISSION_TO_DOWNLOAD_MESSAGE : mLackPermissionToDownloadMessage;
}

@ReactProp(name = "cameraPermissionWhitelist")
public void setCameraPermissionWhitelist(RNCWebView webView, ReadableArray whitelist) {
@ReactProp(name = "cameraPermissionOriginWhitelist")
public void setCameraPermissionOriginWhitelist(RNCWebView webView, ReadableArray whitelist) {
Set<String> whitelistSet = new HashSet<>();
for (int i = 0; i < whitelist.size(); i++) {
whitelistSet.add(whitelist.getString(i));
}

mWebChromeClient.setCameraPermissionWhitelist(whitelistSet);
mWebChromeClient.setCameraPermissionOriginWhitelist(whitelistSet);
}

@ReactProp(name = "javaScriptEnabled")
Expand Down Expand Up @@ -1002,15 +1002,15 @@ protected static class RNCWebChromeClient extends WebChromeClient implements Lif

// True if protected media should be allowed, false otherwise
protected boolean mAllowsProtectedMedia = false;
private Set<String> cameraPermissionWhitelist = new HashSet<>();
private Set<String> cameraPermissionOriginWhitelist = new HashSet<>();

public RNCWebChromeClient(ReactContext reactContext, WebView webView) {
this.mReactContext = reactContext;
this.mWebView = webView;
}

public void setCameraPermissionWhitelist(Set<String> whitelist) {
this.cameraPermissionWhitelist = whitelist;
public void setCameraPermissionOriginWhitelist(Set<String> whitelist) {
this.cameraPermissionOriginWhitelist = whitelist;
}

@Override
Expand Down Expand Up @@ -1074,21 +1074,19 @@ public void onPermissionRequest(final PermissionRequest request) {
grantedPermissions = new ArrayList<>();

ArrayList<String> requestedAndroidPermissions = new ArrayList<>();
String originUrl = request.getOrigin().toString();
String originHost;

try {
URL url = new URL(originUrl);
originHost = url.getHost();
} catch (MalformedURLException e) {
request.deny();
return;
final Uri originUri = request.getOrigin();
final String scheme = originUri.getScheme();
final int port = originUri.getPort();
String origin = scheme + "://" + port;

if (port > 0 && ((scheme == "http" && port != 80) || (scheme == "https" && port != 443))) {
origin += ":" + port;
}

for (String requestedResource : request.getResources()) {
String androidPermission = null;

if (this.cameraPermissionWhitelist.contains(originHost)) {
if (this.cameraPermissionOriginWhitelist.contains(origin)) {
if (requestedResource.equals(PermissionRequest.RESOURCE_VIDEO_CAPTURE)) {
androidPermission = Manifest.permission.CAMERA;
} else if (requestedResource.equals(PermissionRequest.RESOURCE_AUDIO_CAPTURE)) {
Expand Down
24 changes: 8 additions & 16 deletions apple/RNCWebView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
static NSString *const MessageHandlerName = @"ReactNativeWebView";
static NSURLCredential* clientAuthenticationCredential;
static NSDictionary* customCertificatesForHost;
static NSSet *cameraPermissionWhitelist;
static NSSet *cameraPermissionOriginWhitelist;

NSString *const CUSTOM_SELECTOR = @"_CUSTOM_SELECTOR_";

Expand Down Expand Up @@ -71,7 +71,7 @@ @interface RNCWebView () <WKUIDelegate, WKNavigationDelegate, WKScriptMessageHan
@property (nonatomic, strong) WKUserScript *postMessageScript;
@property (nonatomic, strong) WKUserScript *atStartScript;
@property (nonatomic, strong) WKUserScript *atEndScript;
@property (nonatomic, strong) NSArray<NSString *> *cameraPermissionWhitelist;
@property (nonatomic, strong) NSArray<NSString *> *cameraPermissionOriginWhitelist;
@end

@implementation RNCWebView
Expand Down Expand Up @@ -1056,24 +1056,16 @@ - (void) webView:(WKWebView *)webView
initiatedByFrame:(WKFrameInfo *)frame
type:(WKMediaCaptureType)type
decisionHandler:(void (^)(WKPermissionDecision decision))decisionHandler {
if (![self.cameraPermissionWhitelist containsObject:origin.host]) {
decisionHandler(WKPermissionDecisionDeny);
return;
NSString *originString = [NSString stringWithFormat:@"%@://%@", origin.protocol, origin.host];

if (origin.port > 0 && (([origin.protocol isEqualToString:@"http"] && origin.port != 80) || ([origin.protocol isEqualToString:@"https"] && origin.port != 443))) {
Copy link

@633kh4ck 633kh4ck Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: test if protocol is normalized, i.e., ifHttP is treated as http, just in case

Copy link
Author

@mzndako mzndako Feb 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually matter? If HttP is treated as http, the constructed originString won’t match the check below and will be denied.

// Example:
// originString: 'HttPs://camerasite.com'
// cameraPermissionOriginWhitelist: ['https://camerasite.com'] 
if ([self.cameraPermissionOriginWhitelist containsObject:originString]) { // wouldn't match hence denied

I think it’s fine for this case to result in denial, so there’s no need to normalize the protocol.

originString = [originString stringByAppendingFormat:@":%ld", (long)origin.port];
}

if (_mediaCapturePermissionGrantType == RNCWebViewPermissionGrantType_GrantIfSameHost_ElsePrompt || _mediaCapturePermissionGrantType == RNCWebViewPermissionGrantType_GrantIfSameHost_ElseDeny) {
if ([origin.host isEqualToString:webView.URL.host]) {
decisionHandler(WKPermissionDecisionGrant);
} else {
WKPermissionDecision decision = _mediaCapturePermissionGrantType == RNCWebViewPermissionGrantType_GrantIfSameHost_ElsePrompt ? WKPermissionDecisionPrompt : WKPermissionDecisionDeny;
decisionHandler(decision);
}
} else if (_mediaCapturePermissionGrantType == RNCWebViewPermissionGrantType_Deny) {
decisionHandler(WKPermissionDecisionDeny);
} else if (_mediaCapturePermissionGrantType == RNCWebViewPermissionGrantType_Grant) {
if ([self.cameraPermissionOriginWhitelist containsObject:originString]) {
decisionHandler(WKPermissionDecisionGrant);
} else {
decisionHandler(WKPermissionDecisionPrompt);
decisionHandler(WKPermissionDecisionDeny);
}
}
#endif
Expand Down
2 changes: 1 addition & 1 deletion apple/RNCWebViewManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ - (RCTUIView *)view
RCT_EXPORT_VIEW_PROPERTY(cacheEnabled, BOOL)
RCT_EXPORT_VIEW_PROPERTY(allowsLinkPreview, BOOL)
RCT_EXPORT_VIEW_PROPERTY(basicAuthCredential, NSDictionary)
RCT_EXPORT_VIEW_PROPERTY(cameraPermissionWhitelist, NSArray)
RCT_EXPORT_VIEW_PROPERTY(cameraPermissionOriginWhitelist, NSArray)

#if defined(__IPHONE_OS_VERSION_MAX_ALLOWED) && __IPHONE_OS_VERSION_MAX_ALLOWED >= 110000 /* __IPHONE_11_0 */
RCT_EXPORT_VIEW_PROPERTY(contentInsetAdjustmentBehavior, UIScrollViewContentInsetAdjustmentBehavior)
Expand Down
3 changes: 0 additions & 3 deletions src/WebView.android.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {
defaultRenderLoading,
useWebWiewLogic,
versionPasses,
removeHttpsFromOrigins,
} from './WebViewShared';
import {
AndroidWebViewProps,
Expand Down Expand Up @@ -68,7 +67,6 @@ const WebViewComponent = forwardRef<{}, AndroidWebViewProps>((props, ref) => {
scalesPageToFit = true,
saveFormDataDisabled = false,
cacheEnabled = true,
cameraPermissionWhitelist = [],
androidHardwareAccelerationDisabled = false,
androidLayerType = "none",
originWhitelist = defaultOriginWhitelist,
Expand Down Expand Up @@ -209,7 +207,6 @@ const WebViewComponent = forwardRef<{}, AndroidWebViewProps>((props, ref) => {
const webView = <NativeWebView
key="webViewKey"
{...otherProps}
cameraPermissionWhitelist={removeHttpsFromOrigins(cameraPermissionWhitelist)}
messagingEnabled={typeof onMessageProp === 'function'}
messagingModuleName={messagingModuleName}

Expand Down
3 changes: 0 additions & 3 deletions src/WebView.ios.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import {
defaultRenderLoading,
useWebWiewLogic,
versionPasses,
removeHttpsFromOrigins,
} from './WebViewShared';
import {
IOSWebViewProps,
Expand Down Expand Up @@ -73,7 +72,6 @@ const WebViewComponent = forwardRef<{}, IOSWebViewProps>((props, ref) => {
const {
javaScriptEnabled = true,
cacheEnabled = true,
cameraPermissionWhitelist = [],
originWhitelist = defaultOriginWhitelist,
deeplinkWhitelist = defaultDeeplinkWhitelist,
textInteractionEnabled= true,
Expand Down Expand Up @@ -192,7 +190,6 @@ const WebViewComponent = forwardRef<{}, IOSWebViewProps>((props, ref) => {
enableApplePay={enableApplePay}
javaScriptEnabled={javaScriptEnabled}
cacheEnabled={cacheEnabled}
cameraPermissionWhitelist={removeHttpsFromOrigins(cameraPermissionWhitelist)}
dataDetectorTypes={dataDetectorTypes}
useSharedProcessPool={useSharedProcessPool}
textInteractionEnabled={textInteractionEnabled}
Expand Down
4 changes: 0 additions & 4 deletions src/WebViewShared.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,3 @@ export const versionPasses = (version: string | undefined, minimum: string | und
}
return true // equals
}

export const removeHttpsFromOrigins = (whitelist: string[]) => {
return whitelist.map((origin) => origin.replace('https://', ''))
}
4 changes: 2 additions & 2 deletions src/WebViewTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ export interface BasicAuthCredential {

export interface CommonNativeWebViewProps extends ViewProps {
cacheEnabled?: boolean;
cameraPermissionWhitelist?: string[];
cameraPermissionOriginWhitelist?: string[];
incognito?: boolean;
injectedJavaScript?: string;
injectedJavaScriptBeforeContentLoaded?: string;
Expand Down Expand Up @@ -793,7 +793,7 @@ export interface WebViewSharedProps extends ViewProps {
* Defines a list of domain origins that can access camera.
*/

readonly cameraPermissionWhitelist?: string[];
readonly cameraPermissionOriginWhitelist?: string[];

/**
* Stylesheet object to set the style of the container view.
Expand Down
Loading