Skip to content

Conversation

@sayali10
Copy link
Contributor

@sayali10 sayali10 commented Nov 22, 2024

📝 Description

This PR introduces the diff-id input parameter as an alternative to the commit-hash in the Git Comparadise action step.
The action now requires either a commit-hash or a diff-id to be provided, but not both. This allows for more flexible usage of the workflow depending on the use case.

When commit-hash is provided:

  • The workflow follows the usual flow, which includes making GitHub API calls to fetch relevant information about the commit.

When diff-id is provided:

  • The workflow follows a similar process but does not make any GitHub API calls, meaning it operates independently of GitHub’s commit/PR structure.

This new option allows the workflow to be executed without the need for a GitHub pull request (PR) to be created. It can be particularly useful for scenarios where you want to run visual tests without making changes to GitHub or creating PRs.

The action ensures that only one of commit-hash or diff-id is provided, throwing an error if both are supplied.

@sayali10 sayali10 merged commit e4ba79f into ExpediaGroup:main Nov 25, 2024
3 checks passed
@eg-oss-ci
Copy link

🎉 This PR is included in version 1.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants