-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add diff-id input param as alternative to commit-hash #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c180779 to
79d41f4
Compare
sayali10
commented
Nov 22, 2024
sayali10
commented
Nov 22, 2024
sayali10
commented
Nov 22, 2024
sayali10
commented
Nov 22, 2024
danadajian
reviewed
Nov 22, 2024
danadajian
reviewed
Nov 23, 2024
Co-authored-by: Dan Adajian <[email protected]>
Co-authored-by: Dan Adajian <[email protected]>
danadajian
reviewed
Nov 25, 2024
danadajian
approved these changes
Nov 25, 2024
|
🎉 This PR is included in version 1.20.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR introduces the
diff-idinput parameter as an alternative to thecommit-hashin the Git Comparadise action step.The action now requires either a
commit-hashor adiff-idto be provided, but not both. This allows for more flexible usage of the workflow depending on the use case.When commit-hash is provided:
When diff-id is provided:
This new option allows the workflow to be executed without the need for a GitHub pull request (PR) to be created. It can be particularly useful for scenarios where you want to run visual tests without making changes to GitHub or creating PRs.
The action ensures that only one of
commit-hashordiff-idis provided, throwing an error if both are supplied.