Skip to content

fix: tune visual regression tests to be less sensitive#623

Merged
danadajian merged 1 commit intoExpediaGroup:mainfrom
tmichaels2025:tune-visual-tests
Mar 28, 2025
Merged

fix: tune visual regression tests to be less sensitive#623
danadajian merged 1 commit intoExpediaGroup:mainfrom
tmichaels2025:tune-visual-tests

Conversation

@tmichaels2025
Copy link
Contributor

@tmichaels2025 tmichaels2025 commented Mar 27, 2025

📝 Description

  • First iteration of tuning visual tests to be less sensitive to reduce failures on tiny/minor discrepancies
  • Bump alpha value to 0.3 from default value of 0.1 to provide a more opaque diff overlay
  • Bump threshold from 0.3 to 0.5 to allow a slightly higher color difference between images
  • Set includeAA to false instead of using its default value of true to exclude anti-aliasing differences

🔗 Related Issues

  • FUSEFND-581

@tmichaels2025 tmichaels2025 changed the title tune visual regression tests to be less sensitive chore: tune visual regression tests to be less sensitive Mar 27, 2025
@danadajian danadajian changed the title chore: tune visual regression tests to be less sensitive fix: tune visual regression tests to be less sensitive Mar 28, 2025
@danadajian danadajian enabled auto-merge (squash) March 28, 2025 16:54
@danadajian danadajian merged commit 77ab4dd into ExpediaGroup:main Mar 28, 2025
2 checks passed
@eg-oss-ci
Copy link

🎉 This PR is included in version 1.24.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants