refactor: replace env run attempt with context #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created s3Client.ts to export s3 from bun as s3Client for easier mocking - Updated all S3 operations to use Bun's native S3 API: - getKeysFromS3: uses s3Client.list() instead of S3Client.listObjectsV2 - getTemporaryObjectUrl: uses s3Client.presign() instead of getSignedUrl - copyS3File: uses s3Client.file() with exists(), arrayBuffer(), and write() - acceptVisualChanges: updated to use copyS3File helper - Removed @aws-sdk/client-s3 and @aws-sdk/s3-request-presigner dependencies - Updated all tests to mock s3Client instead of reimplementing functions - Fixed test isolation by using beforeEach with mock.clearAllMocks() - All tests pass when run together
- Added CI environment variable support in docker-compose.yml - Modified s3Client.ts to conditionally load credentials based on the CI environment variable
|
🎉 This PR is included in version 1.30.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Related Issues