Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Situation
In the context of our current API operations, the
GetCarsListingsOperationParamsandGetCarsDetailsOperationParamsare incorrectly generating anAcceptheader that requests bothJSONandXMLcontent types. This is causing unnecessary complications and potential issues when interacting with the API.Task
The goal of this change is to ensure that the
Acceptheader only requests theJSONcontent type for the specified operations.Action
To accomplish this task, I have updated the
MustacheHelpers.ktfile to include a newallowedMediaTypesMustache Lambda. This lambda filters out anyXMLcontent types from theAcceptheader, ensuring that onlyJSONcontent types are requested. The specific changes include:Testing
NaN
Results
Fixes SDK-1718.
Notes
NaN