Skip to content

Conversation

@bensbigolbeard
Copy link
Contributor

📝 Description

  • adds fallback for diff attempts through the compare endpoint, which fails with "diff too large" errors for large repos with many deltas between SHAs.
  • the change is to first attempt the existing diff call, then when you receive a 406 (diff too large error code), fetch each sha and use the local git installation to run the diff.
  • new failure states:
    • when diff fails with 40x errors, via octokit.repos.compareCommitsWithBasehead, the catch block processes matching cases, else it's thrown again to match current handling
    • when individual branches/SHAs cannot be retrieved via git.fetch
    • when diffs between two SHAs fail via git.diff

🔗 Related Issues

@sayali10 sayali10 merged commit f8c66ec into main Feb 17, 2025
11 checks passed
@sayali10 sayali10 deleted the diff-fallback branch February 17, 2025 17:11
@eg-oss-ci
Copy link

🎉 This PR is included in version 1.74.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants