-
Notifications
You must be signed in to change notification settings - Fork 1
test(listings): validate Flight Listings endpoint in SDK #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce1bb00 to
7333e81
Compare
02f2591 to
177b5fd
Compare
Member
|
@Ree-maker, please update the PR description, and use |
Author
|
@mohnoor94 Updated the PR with recommended changes. |
mohnoor94
requested changes
Apr 17, 2025
...ain/java/com/expediagroup/sdk/xap/examples/scenarios/flight/FlightListingExampleTesting.java
Show resolved
Hide resolved
...ain/java/com/expediagroup/sdk/xap/examples/scenarios/flight/FlightListingExampleTesting.java
Outdated
Show resolved
Hide resolved
...ain/java/com/expediagroup/sdk/xap/examples/scenarios/flight/FlightListingExampleTesting.java
Show resolved
Hide resolved
mohnoor94
reviewed
Apr 17, 2025
...ain/java/com/expediagroup/sdk/xap/examples/scenarios/flight/FlightListingExampleTesting.java
Outdated
Show resolved
Hide resolved
anssari1
reviewed
Apr 17, 2025
c8cb263 to
53e073e
Compare
anssari1
reviewed
Apr 17, 2025
mohnoor94
previously approved these changes
Apr 20, 2025
Contributor
|
@ExpediaGroup/xap-java-sdk-maintainers can you please review the PR? |
mohnoor94
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
To add Flights Listing API to the SDK.
Task
The goal of this task is to test the SDK integration of the Flight Listings API to support the GenAI partner use case. This includes ensuring that the endpoint is correctly implemented, functioning as expected, and ready for external usage in alignment with the GenAI initiative's delivery schedule.
Action
Implemented and exposed the Flight Listings endpoint within the SDK.
Testing
Conducted local testing of the Listings endpoint using mock data.
Verified that the SDK returns correct data structure for all expected parameters.
Results
Successfully tested the Flight Listings API.
Notes