Skip to content

feat: add custom segment param for flight listings#133

Merged
anssari1 merged 3 commits intomainfrom
nanssari/flights_customization
Apr 24, 2025
Merged

feat: add custom segment param for flight listings#133
anssari1 merged 3 commits intomainfrom
nanssari/flights_customization

Conversation

@anssari1
Copy link
Contributor

@anssari1 anssari1 commented Apr 23, 2025

Situation

GetFlightListingsOperationParams has segment params, for which each piece of detail is passed separately.

GetFlightListingsOperationParams
   .builder()
   .segment1Origin()
   .segment1Destination()
   .segment1DepartureDate()
   .segment2Origin()
   .segment2Destination()
   .segment2DepartureDate()
   .build()

Task

Add a new custom segment data class to hold the details of a segment and pass it to the builder of GetFlightListingsOperationParams

Action

Parse GetFlightListingsOperationParams, and introduce the custom code into it

Testing

Generated an SDK with new customization applied, and tested it manually

GetFlightListingsOperationParams
   .builder()
   .segment1(Segment.builder().origin().destination().departureDate().build())
   .segment2(Segment.builder().origin().destination().departureDate().build())
   .build()

@anssari1 anssari1 requested a review from a team as a code owner April 23, 2025 14:07
@mohnoor94 mohnoor94 self-assigned this Apr 23, 2025
@mohnoor94 mohnoor94 requested review from a team and removed request for a team April 23, 2025 15:17
@anssari1 anssari1 merged commit 6548127 into main Apr 24, 2025
4 checks passed
@anssari1 anssari1 deleted the nanssari/flights_customization branch April 24, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants