Skip to content

Hide the thread that have not been commented #30154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertjchen merged 3 commits into from
Oct 24, 2023
Merged

Hide the thread that have not been commented #30154

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5739b78
Hide the thread that have not been commented
dukenv0307 Oct 23, 2023
e9777a7
don't hide the pinned thread
dukenv0307 Oct 24, 2023
950f37a
Merge branch 'main' into fix/29851
dukenv0307 Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/libs/ReportUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3200,6 +3200,11 @@ function shouldReportBeInOptionList(report, currentReportId, isInGSDMode, betas,
return true;
}

// Hide only chat threads that haven't been commented on (other threads are actionable)
if (isChatThread(report) && canHideReport && isEmptyChat) {
return false;
}

// Include reports that have errors from trying to add a workspace
// If we excluded it, then the red-brock-road pattern wouldn't work for the user to resolve the error
if (report.errorFields && report.errorFields.addWorkspaceRoom) {
Expand Down