Codeblocks web implementation

[BartoszGrajdek]

Explanation of Change

Fixed Issues

$ #39518
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[BartoszGrajdek]

Can I get an adhoc build here? Web should be enough @mountiny

[BartoszGrajdek]

friendly bump @mountiny 😄

[github-actions]

🚧 @mountiny has triggered a test build. You can view the workflow run here.

[BartoszGrajdek]

@mountiny could we get someone from the QA or C+ team to fully test this ^ ad-hoc? I've tested it on a few different devices/browsers and found no issues with it, but we want to ensure there are no regressions before merging this into the react-native-live-markdown main.

[github-actions]

🚧 @mountiny has triggered a test build. You can view the workflow run here.

[github-actions]

🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/56064/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/56064/NewExpensify.dmg	https://56064.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[dukenv0307]

@mountiny There're some conflicts, do we need to resolve them before testing?

[dukenv0307]

@BartoszGrajdek Bug on light mode

[dukenv0307]

[dukenv0307]

Text inside codeblock is not bold

[dukenv0307]

The emojis exceed the bottom edge

[dukenv0307]

Heading style is not applied for text inside code block

[dukenv0307]

Same as italic

[github-actions]

⚠️ This PR is possibly changing native code, it may cause problems with HybridApp. Please run an AdHoc build to verify that HybridApp will not break. ⚠️

[BartoszGrajdek]

@dukenv0307 the fixes are ready, you can go ahead and test them. I believe you should be able to run it locally, just make sure to reinstall node modules

[github-actions]

⚠️ This PR is possibly changing native code, it may cause problems with HybridApp. Please run an AdHoc build to verify that HybridApp will not break. ⚠️

[BartoszGrajdek]

Added a fix to an additional problem I found, but it's still ready for testing @dukenv0307

[dukenv0307]

Thank you @BartoszGrajdek, I'm testing now

[dukenv0307]

@BartoszGrajdek I think the fontSize here isn't correct.

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[Skalakid]

@dukenv0307 Here is the fix

[dukenv0307]

@Skalakid looks good. Can you resolve the conflicts and open the PR?

[Skalakid]

@dukenv0307 so everything is tested and we can open the PR, right? So here is a plan of what we gonna do now:

1. Since the changes are tested I will review and merge the codeblock PR to the Live Markdown library: Implement code and pre blocks support on web react-native-live-markdown#456
2. Open PR to expensify-common with necessary changes
3. Close this PR and create a new one that bumps the version of the Live Markdown library to the version with codeblocks
4. Once all codeblock PRs and this bump PR are merged we can proceed with adding codeblock to the E/App

Let me know what do you think about it :D And thank you for testing!

[dukenv0307]

@Skalakid Yes, that's fine

[dukenv0307]

@Skalakid Any updates?

[Skalakid]

@dukenv0307 I had to prioritize other tasks over codeblocks. Once I'm finished I will come back to it and open all PRs, probably next week

[dukenv0307]

@Skalakid Any updates?

[Skalakid]

No updates from me. We are finishing the current task. So once its done I will focus on code blocks :D

[Skalakid]

Hello, I'm adding the final touches and fixing the last bugs in the Live Markdown code block PR. It should be ready soon. After the PR gets approved, I will merge it and open the PR that adds it to E/App

[dukenv0307]

Thank you @Skalakid for your update

[Skalakid]

Update: The PR is still in progress because I found some critical parsing bugs, where the whole code block structure breaks. Pushed the fix for it today and started testing the solution on all platforms once again :D

[dukenv0307]

@Skalakid

Pushed the fix for it today and started testing the solution on all platforms once again :D

Do we need to test it on all platforms? Since the scope of this PR is for web only

[Skalakid]

@dukenv0307 I think we need to test web only. By "all platforms," I meant Android and iOS web, too. I will finish the codeblock PR today and bump the Live Markdown version here so you can start testing

[dukenv0307]

any updates @Skalakid?

[Skalakid]

@dukenv0307 I'm currently OOO and I will be back on the 2nd of July. The PR with code block implementation is mostly ready; I have addressed all review comments and am waiting for the second review. I will create the PR to E/App when I'm back

[dukenv0307]

@Skalakid any updates?

[Skalakid]

Hello @dukenv0307, the PR is ready, we are just waiting for the last updates, and we need to finish some higher priority tasks before that. @jmusial took over the code block implementation PR, so he will come back to you with more updates about that

[jmusial]

hey @dukenv0307 yeah, I took over but currently involved in other tasks in E/App. Assumed that if this one was open a year it's a lower prio. If you need it let me know I'll bump it up my TODO list 😄

[dukenv0307]

@jmusial Thanks for your update. It has been drafted for a long time ago so I just want to know the current status.

Assumed that if this one was open a year it's a lower prio

I'm not sure about it. cc @mountiny

[jmusial]

@dukenv0307 so expensify dev being down on Fri allowed me to merge the upstream PR in LM repo. Will test the new version with E/App this week and hopefully move this forward 😄

[dukenv0307]

@jmusial any updates?

[Skalakid]

@dukenv0307 codeblocks for web have been merged into E/App in this PR

[dukenv0307]

@mountiny If so, can you please process the payment because I already reviewed this PR? Thanks