-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Text input field - Unable to paste text with CMD + v #65945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-app-2025-07-17_12.56.37.mp4Android: mWeb Chromeandroid-chrome-2025-07-17_13.02.23.mp4iOS: HybridAppios-app-2025-07-17_12.38.58.mp4iOS: mWeb Safariios-safari-2025-07-17_12.42.58.mp4MacOS: Chrome / Safaridesktop-chrome-2025-07-17_12.30.04.mp4MacOS: Desktopdesktop-app-2025-07-17_12.33.25.mp4 |
|
@nkdengineer Sorry, I missed the notification for this! Can you merge main? I'm having some weird dependency errors when trying to build this. |
|
Checking if we're safe to bump this here. |
jjcoffee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@justinpersaud looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
TS checks are unrelated, this is just bumping pkg version |
|
Actually I misspoke, they are related. @nkdengineer you removed |
|
Going to revert, can you please address this / retest? |
|
🚀 Deployed to staging by https://github.com/justinpersaud in version: 9.1.83-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.83-5 🚀
|
Explanation of Change
Fixed Issues
$ #63711
PROPOSAL: #63711 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-07-11.at.22.33.42.mov
Android: mWeb Chrome
Screen.Recording.2025-07-11.at.22.31.10.mov
iOS: Native
Screen.Recording.2025-07-11.at.22.32.39.mov
iOS: mWeb Safari
Screen.Recording.2025-07-11.at.22.29.35.mov
MacOS: Chrome / Safari
Screen.Recording.2025-07-11.at.22.27.40.mov
MacOS: Desktop
Screen.Recording.2025-07-11.at.22.36.09.mov