fix: Two greyed-out RBRs in Inbox v2 #75760

nkdengineer · 2025-11-21T15:26:43Z

Explanation of Change

fix: Two greyed-out RBRs in Inbox

Fixed Issues

$ #74126
#75565
#75592
PROPOSAL: #74126 (comment)

Tests

[Due for payment 2025-11-28] [$250] Two greyed-out RBRs in Inbox #74126

Create a track distance map request
Reset cache and restart
Go to the workspace chat
Open the expense report created above
Verify that no RBR report is displayed in LHN

[Due for payment 2025-11-28] [RCA #74646] Expense - Expense report does not load when opening report after creating expense #75565

Go to workspace chat.
Create an expense.
Immediately click on the expense preview after creating the expense.

[Due for payment 2025-11-28] [RCA #74646] Reports - 0 total amount shown when creating a negative expense with different currency #75592

Click on FAB and select create report
Click on add expense> add unreported expense
Select a different currency from the default workspace currency and flip the amount to negative and click next
Enter a merchant and create expense
Observe total is shown as 0

[Due for payment 2025-11-28] [$250] Two greyed-out RBRs in Inbox #74126

Create a new account and a new workspace
Create a track distance map request
Go to the workspace chat
Open the expense report created above
Open the Console > Application > IndexDB > OnyxDB
Search reportActions_${reportID}, reportID is the reportID of the expense report in the URL
Check and copy the reportActionID of the IOU action
Restart and reset cache
Open the workspace chat
In Console run this script, replace reportID and reportActionID with the ID of expense report and IOU action we searched above.
After run script, open the expense report
Verify that no RBR report is displayed in LHN

Onyx.merge("reportActions_${reportID}", {
    "${reportActionID}": {
        "childReportID": null
    }
});

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-11-08.at.23.38.02.mov

Android: mWeb Chrome

Screen.Recording.2025-11-08.at.23.38.38.mov

iOS: Native

Screen.Recording.2025-11-08.at.23.38.50.mov

iOS: mWeb Safari

Screen.Recording.2025-11-08.at.23.40.48.mov

MacOS: Chrome / Safari

Screen.Recording.2025-11-08.at.23.37.10.mov

Screen.Recording.2025-11-23.at.22.18.01.mov

Screen.Recording.2025-11-23.at.22.18.42.mov

Screen.Recording.2026-01-29.at.16.16.01.mov

MacOS: Desktop

Screen.Recording.2025-11-08.at.23.37.46.mov

codecov · 2025-11-21T15:34:14Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/inbox/ReportScreen.tsx	`67.21% <85.71%> (+0.55%)`	⬆️
... and 27 files with indirect coverage changes

melvin-bot · 2025-11-23T15:23:52Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

joekaufmanexpensify

Good from a product perspective 👍

truph01 · 2025-11-26T10:15:22Z

@nkdengineer Could you help merge main?

nkdengineer · 2025-11-26T10:16:49Z

@truph01 I updated.

truph01 · 2025-11-28T09:11:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

truph01 · 2025-11-28T09:13:41Z

@nkdengineer I encountered a bug when testing the test case #75565

Screen.Recording.2025-11-28.at.16.11.23.mov

nkdengineer · 2025-12-02T10:59:04Z

@truph01 I fixed.

truph01 · 2025-12-04T09:33:16Z

@nkdengineer It looks like we have conflicts.

nkdengineer · 2025-12-04T09:47:57Z

@truph01 Updated.

danielrvidal · 2025-12-19T02:16:34Z

@puneetlath @jamesdeanexpensify can you still see the grayed out RBRs in your LHN?

jamesdeanexpensify · 2025-12-19T17:33:28Z

I don't think I had this issue before, or maybe I'm not remembering?

puneetlath · 2025-12-19T22:01:24Z

I don't have any currently.

nkdengineer · 2025-12-20T04:32:08Z

I mean I can't reproduce the bug here in this PR.

danielrvidal · 2025-12-23T18:54:01Z

So what are the next steps then? Are we thinking this is fixed now or what else are we waiting on?

nkdengineer · 2025-12-30T03:07:53Z

@truph01 Friendly bump.

danielrvidal · 2026-01-05T23:25:39Z

@truph01 can you let us know what the next steps are please?!

truph01 · 2026-01-06T02:14:17Z

I am on it now

truph01 · 2026-01-06T08:52:42Z

@nkdengineer Could you help merge main?

nkdengineer · 2026-01-06T08:56:38Z

@truph01 Done.

truph01 · 2026-01-07T08:25:20Z

@nkdengineer I’m still occasionally able to reproduce the bug:

Screen.Recording.2026-01-07.at.15.23.43.mov

I’m currently working on identifying consistent steps to reproduce it.

nkdengineer · 2026-01-12T08:48:52Z

@truph01 Let me know if you can reproduce it consistently, since I can't reproduce this issue in the PR.

nkdengineer · 2026-01-19T08:22:26Z

@nkdengineer I’m still occasionally able to reproduce the bug:

@truph01 Do you mean you still can reproduce this issue on main or on this PR?

truph01 · 2026-01-19T08:23:30Z

@nkdengineer

@truph01 Do you mean you still can reproduce this issue on main or on this PR?

I mean on this PR

nkdengineer · 2026-01-21T09:27:08Z

@truph01 Still works well on my side. Please help to check again.

truph01 · 2026-01-21T11:14:09Z

I’m no longer able to reproduce the bug I encountered while testing this PR. It's unclear whether that issue has been fully resolved or if it’s just difficult to reproduce.

truph01 · 2026-01-21T11:29:51Z

@nkdengineer

Based on this Slack comment, a backend fix is already in place to ensure that chatReportID is included in the scenario described in this issue. As a result, the frontend PR may now be redundant.

However, @rayane-d pointed out:

I think the FE PR might be unnecessary, as the BE PR will fix this issue, but we can continue with the FE work to prevent this issue from happening again, even if the BE logic changes.

Currently, the test case included in PR author checklist only covers the scenario that has already been addressed by the backend. That means it passes even without the changes introduced in this PR.

Could you add a test case to make sure "prevent this issue from happening again"? For example, we can mock data so that the chatReportID is null before opening the expense report.

nkdengineer · 2026-01-22T15:49:41Z

Could you add a test case to make sure "prevent this issue from happening again"? For example, we can mock data so that the chatReportID is null before opening the expense report.

@nkdengineer Do you mean we don't need the frontend PR or add another mock test to verify?

truph01 · 2026-01-27T23:40:04Z

@nkdengineer I meant that the issue we were trying to fix in this PR has already been resolved by BE.

However, we still need this PR to ensure that a similar bug (which BE can't cover) doesn’t appear again. Could you add one mock test to verify that the same issue won't resurface with our changes?

nkdengineer · 2026-01-29T09:44:13Z

@truph01 I updated the test case and screenshot for this on Web.

truph01 · 2026-02-04T17:24:50Z

src/pages/inbox/ReportScreen.tsx

+    }, [reportMetadata.isOptimisticReport, report, isOffline, isLoadingApp, introSelected, isOnboardingCompleted, isInviteOnboardingComplete, reportIDFromRoute, reportActionIDFromRoute]);
+
+    useEffect(() => {
+        createOneTransactionThreadReportRef.current = createOneTransactionThreadReport;


Why do we need to store createOneTransactionThreadReport in a ref here? Can’t we call createOneTransactionThreadReport directly in line 613 instead?

truph01 · 2026-02-04T17:53:14Z

@nkdengineer Related to this test case:

Based on your proposed solution:

We should only create a transaction thread once the expense report actions are fully loaded, so we can retrieve the childReportID from the report action data. We already have the hasOnceLoadedReportActions flag to check this.

My understanding is:

If the report actions are still loading, we should not create a transaction thread.
If the report actions are loaded and the childReportID is already present, we should also not create a transaction thread.

However, when testing this scenario, I observed that createOneTransactionThreadReportRef.current() is still being called after step 11. This results in a weird report briefly appearing in the LHN.

Screen.Recording.2026-02-05.at.00.45.00.mov

Revert "[CP staging] Revert "fix: Two greyed-out RBRs in Inbox""

a296f01

melvin-bot bot assigned nkdengineer Nov 21, 2025

danielrvidal mentioned this pull request Nov 21, 2025

[Due for payment 2025-11-28] [$250] Two greyed-out RBRs in Inbox #74126

Open

16 tasks

Merge branch 'main' into revert-75598-revert-74646-fix/fix/74126

bc27f80

nkdengineer changed the title ~~Revert "[CP staging] Revert "fix: Two greyed-out RBRs in Inbox""~~ fix: Two greyed-out RBRs in Inbox v2 Nov 23, 2025

fix report doesn't load

85c9483

nkdengineer marked this pull request as ready for review November 23, 2025 15:23

nkdengineer requested review from a team as code owners November 23, 2025 15:23

melvin-bot bot requested review from joekaufmanexpensify and truph01 and removed request for a team November 23, 2025 15:23

joekaufmanexpensify previously approved these changes Nov 24, 2025

View reviewed changes

Merge branch 'main' into revert-75598-revert-74646-fix/fix/74126

458d171

danielrvidal mentioned this pull request Nov 26, 2025

[LHN Bugs] [Tracking] Inbox LHN clean up issues #69786

Closed

nkdengineer added 2 commits December 2, 2025 17:18

Merge branch 'main' into revert-75598-revert-74646-fix/fix/74126

4dc24a0

create a ref to prevent calling twice

4333d94

nkdengineer dismissed joekaufmanexpensify’s stale review via 4333d94 December 2, 2025 10:58

resolve conflict

20cc9a0

huult mentioned this pull request Dec 4, 2025

[HOLD #75760][$250] Expense - Expense details not scrollable on admin side when expense has report fields #73861

Open

16 tasks

Merge branch 'main' into revert-75598-revert-74646-fix/fix/74126

ecaf744

Merge branch 'main' into revert-75598-revert-74646-fix/fix/74126

52f49b4

Merge branch 'main' into revert-75598-revert-74646-fix/fix/74126

6f10ef2

huult mentioned this pull request Jan 13, 2026

[$250] Report - Expense detail page is empty after change workspace #78855

Closed

7 tasks

Merge branch 'main' into revert-75598-revert-74646-fix/fix/74126

e878bd0

nkdengineer added 2 commits January 29, 2026 16:08

Merge branch 'main' into revert-75598-revert-74646-fix/fix/74126

38d029e

Merge branch 'main' into revert-75598-revert-74646-fix/fix/74126

d46882d

truph01 reviewed Feb 4, 2026

View reviewed changes

resolve conflict

1811b8a

fix: Two greyed-out RBRs in Inbox v2 #75760

Are you sure you want to change the base?

fix: Two greyed-out RBRs in Inbox v2 #75760

Conversation

nkdengineer commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Nov 21, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Nov 23, 2025

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

truph01 commented Nov 26, 2025

Uh oh!

nkdengineer commented Nov 26, 2025

Uh oh!

truph01 commented Nov 28, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

truph01 commented Nov 28, 2025

Uh oh!

nkdengineer commented Dec 2, 2025

Uh oh!

truph01 commented Dec 4, 2025

Uh oh!

nkdengineer commented Dec 4, 2025

Uh oh!

danielrvidal commented Dec 19, 2025

Uh oh!

jamesdeanexpensify commented Dec 19, 2025

Uh oh!

puneetlath commented Dec 19, 2025

Uh oh!

nkdengineer commented Dec 20, 2025

Uh oh!

danielrvidal commented Dec 23, 2025

Uh oh!

nkdengineer commented Dec 30, 2025

Uh oh!

danielrvidal commented Jan 5, 2026

Uh oh!

truph01 commented Jan 6, 2026

Uh oh!

truph01 commented Jan 6, 2026

Uh oh!

nkdengineer commented Jan 6, 2026

Uh oh!

truph01 commented Jan 7, 2026

Uh oh!

nkdengineer commented Jan 12, 2026

Uh oh!

nkdengineer commented Jan 19, 2026

Uh oh!

truph01 commented Jan 19, 2026

Uh oh!

nkdengineer commented Jan 21, 2026

Uh oh!

truph01 commented Jan 21, 2026

Uh oh!

truph01 commented Jan 21, 2026

Uh oh!

nkdengineer commented Jan 22, 2026

Uh oh!

truph01 commented Jan 27, 2026

Uh oh!

nkdengineer commented Jan 29, 2026

Uh oh!

truph01 Feb 4, 2026

nkdengineer commented Nov 21, 2025 •

edited

Loading

codecov bot commented Nov 21, 2025 •

edited by github-actions bot

Loading