Part 1: Remove Onyx.connect() for the key: ONYXKEYS.PERSONAL_DETAILS_LIST in src/libs/actions/Report.ts by lorretheboy · Pull Request #77636 · Expensify/App

lorretheboy · 2025-12-14T13:45:19Z

Explanation of Change

Fixed Issues

$ #73656
PROPOSAL: #73656 (comment)

Tests

Test 1:

Login to ND
Open expense chat
Open WS chat
Verify that Create report flow works well
Verify that Create expense flow works well
Go to Report details
Verify that Report details show properly

Test 2 (Only for native device IOS, Android):

Open report from deeplink
Verify that we can open it and the report data is shown properly

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

ANDROID.mov

Screen.Recording.2025-12-14.at.21.52.37.mov

Android: mWeb Chrome

WEBSITE.ANDROID.mov

iOS: Native

ios_0AQlQiwu.mp4

Screen.Recording.2025-12-14.at.21.50.05.mov

iOS: mWeb Safari

WEBSITE.IOS.mov

MacOS: Chrome / Safari

WEBSITE.mov

codecov · 2025-12-14T13:53:56Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`87.50% <ø> (ø)`
.../Search/SearchPageHeader/SearchPageHeaderInput.tsx	`36.89% <50.00%> (+0.33%)`	⬆️
src/libs/actions/Link.ts	`23.31% <0.00%> (ø)`
src/pages/NewChatPage.tsx	`75.00% <0.00%> (ø)`
src/pages/Search/SearchMoneyRequestReportPage.tsx	`0.00% <0.00%> (ø)`
src/components/PromotedActionsBar.tsx	`36.36% <0.00%> (ø)`
...rc/components/Search/SearchRouter/SearchRouter.tsx	`0.00% <0.00%> (ø)`
src/pages/Share/ShareDetailsPage.tsx	`0.00% <0.00%> (ø)`
src/pages/ProfilePage.tsx	`0.00% <0.00%> (ø)`
src/pages/NewChatConfirmPage.tsx	`0.00% <0.00%> (ø)`
... and 1 more
... and 11 files with indirect coverage changes

melvin-bot · 2025-12-14T13:58:19Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-12-14T13:58:53Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2025-12-14T15:18:50Z

src/pages/NewChatPage.tsx

    const [isSearchingForReports] = useOnyx(ONYXKEYS.IS_SEARCHING_FOR_REPORTS, {initWithStoredValues: false, canBeMissing: true});
    const [reportAttributesDerived] = useOnyx(ONYXKEYS.DERIVED.REPORT_ATTRIBUTES, {canBeMissing: true, selector: reportsSelector});
    const selectionListRef = useRef<SelectionListHandle | null>(null);
+    const [allPersonalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {canBeMissing: true});


use personalDetails hook instead.

…-01/73656

grgia

@lorretheboy would you ping when tests are passing

grgia · 2025-12-18T11:18:21Z

src/pages/Search/SearchMoneyRequestReportPage.tsx

    const transactionThreadReportID = getOneTransactionThreadReportID(report, chatReport, reportActions ?? [], isOffline, reportTransactionIDs);
    const oneTransactionID = reportTransactions.at(0)?.transactionID;
-
+    const [personalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {canBeMissing: true});


should we use the hook here too

According to [PERF-3] Use OnyxListItemProvider hooks instead of useOnyx in renderItem, we should use the hook if it is inside the render list of a flatlist. So I think we dont need it for this case. Wdyt?

github-actions · 2025-12-18T11:36:13Z

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-12-18T11:41:46Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #77636.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	https://77636.pr-testing.expensify.com
The build for Desktop was skipped

👀 View the workflow run that generated this build 👀

JmillsExpensify

No product review required.

…-01/73656

grgia

@lorretheboy would you please merge main so it's up to date with latest, since it's been a few weeks during the holidays 🙇

…-01/73656

lorretheboy · 2026-01-05T15:27:07Z

Merged main

parasharrajat · 2026-01-10T09:07:25Z

Bump @lorretheboy

…-01/73656

grgia · 2026-01-12T17:16:01Z

what's the latest here @lorretheboy

lorretheboy · 2026-01-12T18:33:04Z

@parasharrajat @grgia It is ready for re-review now. Thxx for waiting

parasharrajat · 2026-01-12T18:45:13Z

src/pages/Share/ShareDetailsPage.tsx

+                            })) ?? [];
+
+                    const ownerAccountID = report.ownerAccountID;
+                    if (ownerAccountID && personalDetails?.[ownerAccountID]) {


you should pass reportOwnerPersonalDetails in a different param not in participants.

parasharrajat · 2026-01-12T18:48:42Z

src/pages/Share/ShareDetailsPage.tsx

-                        undefined,
-                        undefined,
-                    );
+                    const participants: ParticipantInfo[] =


When I asked to pass personaldetails of participants and owner as param. I also meant that instead of subscribing to whole ONYXKEYS.PERSONAL_DETAILS_LIST collection, we should only subscribe to participants and owner user's personal details.

So you should update the logic to use a selector in following subscription which filters the personal details for necessary users only.

If we can't create selector dynamically at some places then we should use the personalDetails hook instead.

parasharrajat · 2026-01-14T14:14:47Z

bump @lorretheboy

parasharrajat · 2026-01-18T14:20:40Z

@lorretheboy Let us know when this is ready again.

lorretheboy · 2026-01-19T03:20:51Z

It is ready for review last week. Sorry I forgot to ping you. It's now conflict again, lemme resolve it

parasharrajat · 2026-01-26T17:42:15Z

@lorretheboy More Conflicts.

parasharrajat · 2026-02-02T17:19:17Z

@lorretheboy Conflicts.

parasharrajat

Can we use const personalDetails = usePersonalDetails(); hook instead where possible?

parasharrajat · 2026-02-04T06:51:16Z

src/pages/Share/ShareDetailsPage.tsx

+                        displayReport.participantsList
+                            ?.filter((u) => u.accountID !== personalDetail.accountID)
+                            .map((u) => ({
+                                login: u.login ?? '',
+                                accountID: u.accountID,
+                                personalDetails: personalDetails?.[u.accountID] ?? undefined,
+                            })) ?? [];
+
+                    const ownerPersonalDetails = report?.ownerAccountID && personalDetails?.[report?.ownerAccountID] ? personalDetails[report?.ownerAccountID] : undefined;


I guess there is no use of this now as we are already subscribing to whole personaldetails collection....

As per my previous comment, we can't use the selector pattern now. Do you still see any benefit of passing only participants and owner personal details.

@lorretheboy Can you check this?

parasharrajat · 2026-02-08T13:34:09Z

Bump @lorretheboy. I am ready to close this fast, but if you handlethe requested changes in a timely manner.

lorretheboy · 2026-02-08T15:40:42Z

Can we use const personalDetails = usePersonalDetails(); hook instead where possible?

Done. The current code is following this documentation

fix part 1: remove onyx.connect for personal details list

2d94986

melvin-bot bot assigned lorretheboy Dec 14, 2025

lorretheboy marked this pull request as ready for review December 14, 2025 13:58

lorretheboy requested review from a team as code owners December 14, 2025 13:58

melvin-bot bot requested review from JmillsExpensify and parasharrajat December 14, 2025 13:58

melvin-bot bot requested review from a team and grgia and removed request for a team December 14, 2025 13:58

lorretheboy mentioned this pull request Dec 14, 2025

$250 Remove Onyx.connect() for the key: ONYXKEYS.PERSONAL_DETAILS_LIST in src/libs/actions/Report.ts #73656

Open

parasharrajat suggested changes Dec 14, 2025

View reviewed changes

lorretheboy added 2 commits December 16, 2025 23:44

Merge branch 'main' of https://github.com/Expensify/App into fix-part…

1df50f9

…-01/73656

fix: resolve comment

9e8a14f

grgia reviewed Dec 18, 2025

View reviewed changes

JmillsExpensify reviewed Dec 18, 2025

View reviewed changes

lorretheboy added 3 commits December 22, 2025 18:50

fix: conflicts

2b662ff

fix: linter

8cc9059

Merge branch 'main' of https://github.com/Expensify/App into fix-part…

cbe83fe

…-01/73656

grgia reviewed Jan 5, 2026

View reviewed changes

Merge branch 'main' of https://github.com/Expensify/App into fix-part…

27f8bc1

…-01/73656

lorretheboy added 5 commits January 11, 2026 13:47

Merge branch 'main' of https://github.com/Expensify/App into fix-part…

f3a76c0

…-01/73656

fix: react compiler issue

0dc9ecf

fix: revert changes

d1e7a4c

fix: optimize params

ce1f895

fix: combine params

ded38cb

lorretheboy added 4 commits January 13, 2026 00:37

fix: conflicts

4e9817e

fix: test

41f31ad

fix: lint

b97c657

fix: lint

9bc7217

parasharrajat suggested changes Jan 12, 2026

View reviewed changes

lorretheboy added 2 commits January 14, 2026 17:04

fix: conflicts

31e281e

fix: params

14e357d

lorretheboy added 3 commits January 15, 2026 13:47

fix: add personalDetailsSelector

2e71539

fix: conflicts

9c3ef71

fix: deps

d927027

fix: conflicts

cff814d

parasharrajat suggested changes Feb 4, 2026

View reviewed changes

parasharrajat reviewed Feb 4, 2026

View reviewed changes

lorretheboy added 2 commits February 8, 2026 22:33

fix: conflicts

993578c

fix: rebase main

644c6d1

Conversation

lorretheboy commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Dec 14, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Dec 14, 2025

Uh oh!

melvin-bot bot commented Dec 14, 2025

Uh oh!

parasharrajat Dec 14, 2025

Choose a reason for hiding this comment

Uh oh!

lorretheboy Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

grgia left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

grgia Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

lorretheboy Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

lorretheboy commented Jan 5, 2026

Uh oh!

parasharrajat commented Jan 10, 2026

Uh oh!

grgia commented Jan 12, 2026

Uh oh!

lorretheboy commented Jan 12, 2026

Uh oh!

parasharrajat Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

parasharrajat Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Jan 14, 2026

Uh oh!

parasharrajat commented Jan 18, 2026

Uh oh!

lorretheboy commented Jan 19, 2026

Uh oh!

parasharrajat commented Jan 26, 2026

Uh oh!

parasharrajat commented Feb 2, 2026

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Uh oh!

parasharrajat Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

parasharrajat Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Feb 8, 2026

lorretheboy commented Dec 14, 2025 •

edited

Loading

codecov bot commented Dec 14, 2025 •

edited by github-actions bot

Loading

grgia left a comment •

edited

Loading

parasharrajat Jan 12, 2026 •

edited

Loading