-
Notifications
You must be signed in to change notification settings - Fork 3.5k
chore: bump react-native-pager-view to v7.0.2 #78257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump react-native-pager-view to v7.0.2 #78257
Conversation
|
|
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppbefore: before.movafter: after.moviOS: mWeb SafariMacOS: Chrome / Safari |
|
@mdneyazahmad this package is also used in I tested and it works fine Screen.Recording.2025-12-22.at.12.52.11.pm.mov |
aimane-chnaif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Valforte let's also merge https://github.com/Expensify/Mobile-Expensify/pull/13811 simultaneously.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Valforte in version: 9.2.86-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.86-4 🚀
|
Explanation of Change
An iOS-only issue exists in the current version of
react-native-pager-view(see issue). The issue is fixed in versionv7.0.2, and this PR upgrades the dependency to that version.Fixed Issues
$ #77894
PROPOSAL: #77894 (comment)
Tests
Screens
For the above screens, perform the following steps
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
native-ios.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari