[No QA] Add debug button to clear the useSidebarOrderedReports cache #78962
+60
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
JmillsExpensify and
huult
and removed request for
a team
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 3bf6eb8e..7434712b 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -1859,6 +1859,8 @@ const translations: TranslationDeepObject<typeof en> = {
sentryDebugDescription: 'Sentry-Anfragen in der Konsole protokollieren',
sentryHighlightedSpanOps: 'Hervorgehobene Span-Namen',
sentryHighlightedSpanOpsPlaceholder: 'ui.interaction.click, navigation, ui.load',
+ leftHandNavCache: 'Cache für linke Seitenleiste',
+ clearleftHandNavCache: 'Löschen',
},
debugConsole: {
saveLog: 'Protokoll speichern',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index db35ff17..ae4aa6de 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -1860,6 +1860,8 @@ const translations: TranslationDeepObject<typeof en> = {
sentryDebugDescription: 'Enregistrer les requêtes Sentry dans la console',
sentryHighlightedSpanOps: 'Noms de spans mis en valeur',
sentryHighlightedSpanOpsPlaceholder: 'ui.interaction.click, navigation, ui.load',
+ leftHandNavCache: 'Cache de navigation gauche',
+ clearleftHandNavCache: 'Effacer',
},
debugConsole: {
saveLog: 'Enregistrer le journal',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index ca553040..f5f8c770 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -1853,6 +1853,8 @@ const translations: TranslationDeepObject<typeof en> = {
sentryDebugDescription: 'Registra le richieste Sentry nella console',
sentryHighlightedSpanOps: 'Nomi degli span evidenziati',
sentryHighlightedSpanOpsPlaceholder: 'ui.interaction.click, navigation, ui.load',
+ leftHandNavCache: 'Cache della navigazione sinistra',
+ clearleftHandNavCache: 'Cancella',
},
debugConsole: {
saveLog: 'Salva registro',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 04ae3d17..933e90ff 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -1852,6 +1852,8 @@ const translations: TranslationDeepObject<typeof en> = {
sentryDebugDescription: 'Sentryリクエストをコンソールに記録',
sentryHighlightedSpanOps: 'ハイライト表示するspan名',
sentryHighlightedSpanOpsPlaceholder: 'ui.interaction.click, navigation, ui.load',
+ leftHandNavCache: '左側ナビキャッシュ',
+ clearleftHandNavCache: 'クリア',
},
debugConsole: {
saveLog: 'ログを保存',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 06e93f0a..d500753d 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1852,6 +1852,8 @@ const translations: TranslationDeepObject<typeof en> = {
sentryDebugDescription: 'Sentry-verzoeken naar console loggen',
sentryHighlightedSpanOps: 'Geresalteerde spannamen',
sentryHighlightedSpanOpsPlaceholder: 'ui.interaction.click, navigation, ui.load',
+ leftHandNavCache: 'Cache van linkernavigatie',
+ clearleftHandNavCache: 'Wissen',
},
debugConsole: {
saveLog: 'Log opslaan',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index e55050b7..4ff76881 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -1849,6 +1849,8 @@ const translations: TranslationDeepObject<typeof en> = {
sentryDebugDescription: 'Rejestruj żądania Sentry w konsoli',
sentryHighlightedSpanOps: 'Nazwy wyróżnionych spanów',
sentryHighlightedSpanOpsPlaceholder: 'ui.interaction.click, navigation, ui.load',
+ leftHandNavCache: 'Pamięć podręczna lewego panelu nawigacyjnego',
+ clearleftHandNavCache: 'Wyczyść',
},
debugConsole: {
saveLog: 'Zapisz log',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 66f72484..3f17144f 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -1848,6 +1848,8 @@ const translations: TranslationDeepObject<typeof en> = {
sentryDebugDescription: 'Registrar solicitações do Sentry no console',
sentryHighlightedSpanOps: 'Nomes de spans destacados',
sentryHighlightedSpanOpsPlaceholder: 'ui.interaction.click, navigation, ui.load',
+ leftHandNavCache: 'Cache da navegação lateral esquerda',
+ clearleftHandNavCache: 'Limpar',
},
debugConsole: {
saveLog: 'Salvar log',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index d7e82bb9..471ad47f 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -1825,6 +1825,8 @@ const translations: TranslationDeepObject<typeof en> = {
sentryDebugDescription: '将Sentry请求记录到控制台',
sentryHighlightedSpanOps: '突出显示的Span名称',
sentryHighlightedSpanOpsPlaceholder: 'ui.interaction.click, navigation, ui.load',
+ leftHandNavCache: '左侧导航缓存',
+ clearleftHandNavCache: '清除',
},
debugConsole: {
saveLog: '保存日志',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
8 tasks
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-07.at.10.08.07.mp4Android: mWeb ChromeScreen.Recording.2026-01-07.at.10.08.51.mp4iOS: HybridAppScreen.Recording.2026-01-07.at.10.10.31.mp4iOS: mWeb SafariScreen.Recording.2026-01-07.at.10.11.30.mp4MacOS: Chrome / SafariScreen.Recording.2026-01-07.at.10.04.40.mp4 |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Contributor
|
@chuckdries Please fix the Prettier check |
huult
reviewed
Jan 7, 2026
grgia
approved these changes
Jan 8, 2026
grgia
deleted the
chuckdries/useSidebarOrderedReports-clear-cache-button
branch
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
We've been seeing issues with LHN data being wrong in the wild for a while now. I have a theory about why it happens, but it's tricky to reproduce on purpose. I'm going to keep trying, but in the mean time this PR adds a button to the cmd+D modal to clear the LHN data cache and re-compute it all from the Onyx data. This is meant to be a quick hack to prove that I'm right. If pressing this button fixes your LHN, that's proof that the cache was stale (as opposed to the onyx data itself being stale).
Fixed Issues
$ #76165
PROPOSAL:
Tests
[useSidebarOrderedReports] Clearing sidebar cache manually via debug modaland[useSidebarOrderedReports] building reportsToDisplay from scratchOffline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari