refactor: company card feed types and utils

[chrispader]

@carlosmiceli @joekaufmanexpensify

Explanation of Change

Refactorings around types and utils for company card feeds.

Fixed Issues

#76438

PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	87.50% <ø> (ø)
...ponents/ReportActionAvatars/ReportActionAvatar.tsx	86.53% <ø> (ø)
src/components/ReportActionAvatars/index.tsx	100.00% <ø> (ø)
src/hooks/useCardFeedsForDisplay.ts	72.72% <ø> (ø)
src/hooks/useCompanyCards.ts	100.00% <ø> (ø)
src/libs/CardFeedUtils.ts	89.69% <100.00%> (ø)
src/libs/PolicyUtils.ts	56.03% <100.00%> (ø)
src/libs/TransactionUtils/index.ts	75.71% <100.00%> (-0.10%)	⬇️
...libs/actions/OnyxDerived/configs/cardFeedErrors.ts	97.05% <100.00%> (ø)
src/libs/actions/Policy/Member.ts	74.74% <100.00%> (ø)
... and 19 more
... and 11 files with indirect coverage changes

[melvin-bot]

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac25b86ab2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[ikevin127]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

[chrispader]

@carlosmiceli i fixed TS errors, merged main and addressed all comments by @ikevin127, except for this issue:

2. Assign a company card to a workspace member 🔴 (FAILED) - Not present on Staging ♻️
   Navigate to Workspace → Company Cards
   Click "Assign card" on an unassigned card
   Select a member and confirm
   Verify card appears assigned in the list with correct member name ⚠️
   Precondition:

There must be at least 2 feeds added (e.g. Chase/Regions Bank)
The user must assign itself a card example Plaid Checking 0000
Actual result:

When user attempts to assign itself a card with same Plaid Checking 0000 but on the other feed:
User is presented with error 🔴 This card is already assigned to a user in another workspace. despite being a different feed - this does not happen on Staging where assignment works

@ikevin127 how can i achieve to have two card feeds with the same card names? Also, if these are different feeds, should assigning a card with the same name really throw an error? Naturally, i feel like this should work, right?

[carlosmiceli]

When user attempts to assign itself a card with same Plaid Checking 0000 but on the other feed:
User is presented with error 🔴 This card is already assigned to a user in another workspace. despite being a different feed - this does not happen on Staging where assignment works

@ikevin127 @chrispader I'm trying to understand the bug, steps read a bit confusing to me and can't figure it out from the video. Is the same card being assigned twice? Different feeds with the same card? We're working on a BE fix for preventing assignment for the same card despite being in different domains/workspaces (issue), would that fix this too?

[ikevin127]

Here are complete steps for that issue (that happens only on this PR) starting from scratch:

Preconditions:

• ensure Use Staging Server is ON
• a workspace with BA added in Workflows section

1. Go to Company cards and make sure there's no feed added > Add cards > Direct feed > Other.
2. During Plaid flow select Regions Bank and first checkbox account (Plaid Checking - 0000) and complete feed addition.
3. Same as step 2 but this time select Chase bank and also select first checkbox account (Checking - 0000) and complete feed addition.
4. Now with both feeds added, try and assign a card to the same user (yourself) on each feed.
5. First feed-card assignment works, but on the second feed assignment: notice how when attempting to assign the card we get error (🗒️ this does not happen on staging, only on this PR).

Screen.Recording.2026-01-27.at.15.56.46.mov

cc @chrispader @carlosmiceli Hope its more clear now 🙌

[carlosmiceli]

@chrispader do these steps help to try to reproduce/fix what Kevin found?

[chrispader]

a workspace with BA added in Workflows section

You mean with a bank account added under "Payments"? How can i do that? I have never used that before

During Plaid flow select Regions Bank and first checkbox account (Plaid Checking - 0000) and complete feed addition.

@ikevin127 i'm prompted for Regions Bank account credentials? Should this step be omitted or do you have any credentials for me?

[ikevin127]

@chrispader It's the test BA credential regardless of bank (this while on staging server):

ID: user_good
Pass: pass_good
Mobile code: credential_good

[chrispader]

@ikevin127 ahh thanks, totally missed the grey bar at the bottom saying exactly this. thanks haha

I was just able to reproduce this issue, but also on main/staging. @ikevin127 could you confirm that you're also able to repro on main? 🙌🏼

Screen.Recording.2026-02-06.at.15.07.28.mov

Nevertheless, I fixed this issue in 8da8bf7

[ikevin127]

I was just able to reproduce this issue, but also on main/staging. @ikevin127 could you confirm that you're also able to repro on main? 🙌🏼

@chrispader Weird that it's reproducible on staging as well now - and it wasn't before.

This feels like an issue to me though, but in a real world scenarios it's rare that 2 different banks would have the same feed key for this logic to block the user from assigning card to the same user and for 2 different bank accounts to have the same key.

🟢 Approved

[melvin-bot]

🎯 @ikevin127, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #81759.

[carlosmiceli]

@chrispader We have failing tests 🫡