fix: attendee field doesn't show the assigned person #81483

NJ-2020 · 2026-02-05T07:31:34Z

Explanation of Change

Fallback creatorDetails?.login to creatorDetails?.displayName to handle empty string

Fixed Issues

$ #80687
PROPOSAL: #80687 (comment)

Tests

Preconditions: Rules are enabled > Enable Attendee tracking

As User A, create two expenses in the workspace chat
Open the expense report, mention User B and send it to the report.
Click Invite to chat only.
As User B, open the report.
Verify that: User B can see the assigned person in the attendee field.

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-02-06.at.17.41.15.mov

Android: mWeb Chrome

Screen.Recording.2026-02-06.at.17.33.17.mov

iOS: Native

Screen.Recording.2026-02-06.at.17.17.57.mov

iOS: mWeb Safari

Screen.Recording.2026-02-06.at.17.27.48.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-06.at.17.25.03.mov

melvin-bot · 2026-02-06T10:42:41Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-02-06T10:45:14Z

Code Review Summary

I've reviewed PR #81483. Here are my findings:

⚠️ Variable Naming Issue

File: src/libs/TransactionUtils/index.ts:1163

Issue: The variable creatorEmail may now contain a display name instead of an email, which is misleading:

const creatorEmail = creatorDetails?.login ?? creatorDetails?.displayName ?? '';

Impact:

While the fix addresses the immediate issue (attendee field not showing), the variable name creatorEmail no longer accurately reflects its contents
This could cause confusion for future maintainers who expect this variable to contain an email address
The subsequent line uses this value correctly for display purposes: const creatorDisplayName = creatorDetails?.displayName ?? creatorEmail;

Recommendation: Consider renaming creatorEmail to something more generic like creatorIdentifier or creatorLogin to better reflect that it can contain either a login or display name.

✅ Logic Correctness

The fallback chain logic is sound and will properly handle cases where login is empty or undefined by falling back to displayName.

Note

The change successfully addresses issue #80687 where the attendee field doesn't show the assigned person when login is empty.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ca87f6b725

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-06T10:48:20Z

src/libs/TransactionUtils/index.ts

        const [creatorDetails] = getPersonalDetailsByIDs({accountIDs: [creatorAccountID], currentUserAccountID: currentUserPersonalDetails?.accountID});
-        const creatorEmail = creatorDetails?.login ?? '';
+        const creatorEmail = creatorDetails?.login ?? creatorDetails?.displayName ?? '';
        const creatorDisplayName = creatorDetails?.displayName ?? creatorEmail;


Handle empty login strings when building attendee email

When creatorDetails.login is an empty string (the case described in the PR), the ?? operator will not fall back, so creatorEmail remains '' and the function still returns no attendee. That means the assigned person will continue to be missing in the attendee field for that scenario. If the intent is to treat empty string as missing, this needs an explicit empty-string check (e.g., ||) instead of nullish coalescing.

Useful? React with 👍 / 👎.

NJ-2020 · 2026-02-06T10:54:52Z

⚠️ Variable Naming Issue

Done ✅

truph01 · 2026-02-06T11:29:46Z

@NJ-2020 We have lint issues

NJ-2020 · 2026-02-07T01:24:13Z

Done

trjExpensify

Looks to be addressing a follow-up from a PR @ikevin127 and @JS00001 were working on to introduce category required attendees. 👍

truph01 · 2026-02-11T09:34:15Z

@NJ-2020 We have spell-check issue, could you help check?

truph01 · 2026-02-11T09:57:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-02-11.at.16.55.15.mov

Android: mWeb Chrome

Screen.Recording.2026-02-11.at.16.56.52.mov

iOS: HybridApp

Screen.Recording.2026-02-11.at.16.55.47.mov

iOS: mWeb Safari

Screen.Recording.2026-02-11.at.16.56.29.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-11.at.16.51.03.mov

github-actions · 2026-02-11T12:45:47Z

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-11T12:49:38Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81483.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b012759-d627a9d4e7da2aa9e09b2b98a4117af1e99f4616/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b012759-eaf0ce783237de1b732f9182d4cf122923d5c625/index.html

Web 🕸️
https://81483.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-11T12:53:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

fix: attendee field doesn't show the assigned person

fdc83bd

melvin-bot bot assigned NJ-2020 Feb 5, 2026

Merge branch 'Expensify:main' into fix/80687

ca87f6b

NJ-2020 marked this pull request as ready for review February 6, 2026 10:42

NJ-2020 requested review from a team as code owners February 6, 2026 10:42

melvin-bot bot requested review from trjExpensify and truph01 and removed request for a team February 6, 2026 10:42

melvin-bot bot removed the request for review from a team February 6, 2026 10:42

chatgpt-codex-connector bot reviewed Feb 6, 2026

View reviewed changes

NJ-2020 mentioned this pull request Feb 6, 2026

[$250] Attendees field - Attendees field shows only title to the invited to the report user #80687

Open

7 tasks

fix: variable name && nullish coalescing

3c20b14

NJ-2020 and others added 2 commits February 7, 2026 08:12

fix: lint error

47004a1

Merge branch 'Expensify:main' into fix/80687

b315c6c

Merge branch 'Expensify:main' into fix/80687

dbbfe8b

trjExpensify approved these changes Feb 9, 2026

View reviewed changes

luacmartins self-requested a review February 9, 2026 17:41

Merge branch 'Expensify:main' into fix/80687

6be82cb

truph01 approved these changes Feb 11, 2026

View reviewed changes

JS00001 approved these changes Feb 11, 2026

View reviewed changes

JS00001 merged commit b012759 into Expensify:main Feb 11, 2026
30 checks passed

fix: attendee field doesn't show the assigned person #81483

fix: attendee field doesn't show the assigned person #81483

Conversation

NJ-2020 commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026

Code Review Summary

⚠️ Variable Naming Issue

✅ Logic Correctness

Note

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

NJ-2020 Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

NJ-2020 commented Feb 6, 2026

Uh oh!

truph01 commented Feb 6, 2026

Uh oh!

NJ-2020 commented Feb 7, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

truph01 commented Feb 11, 2026

Uh oh!

truph01 commented Feb 11, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

OSBotify commented Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

NJ-2020 commented Feb 5, 2026 •

edited

Loading