Skip to content

Conversation

@cristipaval
Copy link
Contributor

@cristipaval cristipaval commented Feb 10, 2026

Explanation of Change

This PR hides the options to pay invoices with bank accounts or cards via Expensify. Even if invoices are not promoted in NewDot yet, we realised that some users use them, and we have an issue that prevents the senders from getting the funds in their bank account. Here is another Slack thread where you can see a user having the same problem. We decided not to prioritize fixing this right now, because this would require product changes, and it might not be worth it since #billpay is on the roadmap for sometime later this year.

Fixed Issues

#67218
PROPOSAL:

Tests

Test that the invoices can only be marked as paid from Reports/Search and from the invoice rooms.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Test that invoices can only be marked as paid; they can't be paid via Expensify.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-02-11.at.13.36.03.mov

@cristipaval cristipaval requested a review from MariaHCD February 10, 2026 20:47
@cristipaval cristipaval self-assigned this Feb 10, 2026
@cristipaval cristipaval requested review from a team as code owners February 10, 2026 20:47
@cristipaval cristipaval added the InternalQA This pull request required internal QA label Feb 10, 2026
@melvin-bot melvin-bot bot requested review from heyjennahay and youssef-lr and removed request for a team February 10, 2026 20:48
@melvin-bot
Copy link

melvin-bot bot commented Feb 10, 2026

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team February 10, 2026 20:48
@github-actions
Copy link
Contributor

Code Review Summary

I've completed a comprehensive review of PR #82046. The changes successfully implement hiding invoice payment via Expensify behind a beta flag.

Key Findings

Code Duplication (CONSISTENCY-3)
I found that the same invoice payment options logic pattern is duplicated across three files:

  • src/components/SettlementButton/index.tsx
  • src/hooks/useBulkPayOptions.ts
  • src/hooks/usePaymentOptions.ts

Each file independently implements:

  • A getInvoicesOptionsMarkAsPaidOnly function that returns "pay elsewhere" option only
  • A getInvoicesOptionsFull function that returns full payment options including bank accounts/cards
  • Logic to select between them based on the beta flag

Recommendation: Consider extracting this shared logic into a utility function or shared hook to reduce duplication and make future maintenance easier.

Overall Assessment

The implementation is functionally correct and follows the existing patterns in the codebase. The beta flag approach is appropriate for this use case. While there's code duplication, it's consistent with the current architectural patterns where each component/hook manages its own payment options independently.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c797b8a56d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 87.39% <ø> (ø)
src/hooks/useBulkPayOptions.ts 46.93% <25.00%> (+1.10%) ⬆️
src/hooks/usePaymentOptions.ts 0.00% <0.00%> (ø)
src/components/SettlementButton/index.tsx 0.00% <0.00%> (ø)
... and 65 files with indirect coverage changes

@cristipaval cristipaval changed the title Hide paying invoices via Expensify behind a beta [WIP] Hide paying invoices via Expensify behind a beta Feb 10, 2026
@cristipaval cristipaval force-pushed the cristi_hide-PayInvoice-via-Expensify branch from 04baf28 to 5d9bf9d Compare February 11, 2026 11:24
@cristipaval
Copy link
Contributor Author

@codex review
@claude review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5d9bf9d1f6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@cristipaval cristipaval changed the title [WIP] Hide paying invoices via Expensify behind a beta Hide paying invoices via Expensify behind a beta Feb 11, 2026
@cristipaval cristipaval requested a review from getusha February 11, 2026 12:54
@cristipaval
Copy link
Contributor Author

@getusha , I see you reviewed the PR that aligned invoice payment with the settlement button. Could you please review the current PR as well? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

InternalQA This pull request required internal QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant