Conversation
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34ebe0693e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <ActivityIndicator size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE} /> | ||
| </View> | ||
| ); | ||
| if (isLoadingApp || isLoadingReportData) { |
There was a problem hiding this comment.
IS_LOADING_REPORT_DATA is set to true for every OpenApp/Reconnect cycle (see getOnyxDataForOpenOrReconnect in src/libs/actions/App.ts), even when cached DERIVED.TODOS data already exists, so this unconditional check now replaces valid For You actions with a skeleton during background refreshes/reconnects. That regresses usability because users temporarily lose working quick-action buttons despite having renderable data; the loading state should be gated on missing todos data rather than any report-data refresh.
Useful? React with 👍 / 👎.
|
This feels good to me. I like the three skellys. Part of me wonder if it should be two maybe because it feels more realistic, but I can't say why lol 😂 ! cc @Expensify/design for second set of eyes |
|
Heh, I think I might agree - we're more likely to have two rows instead of 3 is my guess? I really like how you are rounding the edges of these bars here: Which makes me think... should we update that everywhere? Those bars are not rounded in any other skeleton context. So for the sake of consistency, I would think we'd make that improvement to all of them (assuming it's a quick fix). |
|
@dubielzyk-expensify @shawnborton thanks for the review, I pushed the above suggested changes! While Loading: After: I noticed will testing that here that we've got a weird skeleton state on the search page- was it intentional to make the title rows skeletons too? |
|
I believe that was intentional, yes. In your screenshots, everything looks like full 90deg corners though... are those supposed to be rounded? |
|
@shawnborton that screenshot is from staging Edit: |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@codex review |
|
I added a component for the roundedness, but am tweaking them to match |
|
border radius 2 vs 3 vs 4
|
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
3 participants
Explanation of Change
Skeleton!!
Fixed Issues
$ #81846
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps./** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari