-
Notifications
You must be signed in to change notification settings - Fork 103
[HOLD] Adjust workflows to properly run style on branches #2429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # This is for all external BE contributors' test runs. | ||
| # The goal is so that they cannot explicitly push changes to the workflow to print | ||
| # sensitive information. | ||
| name: Forked Test Suite | ||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize] | ||
| branches-ignore: [production] | ||
| jobs: | ||
| Automated-Tests: | ||
| name: Automated Tests | ||
| # This shows that its a fork | ||
| if: ${{ github.event.pull_request.head.repo.full_name != github.repository }} | ||
| uses: ./.github/workflows/bedrock.yml | ||
| with: | ||
| is_fork: true | ||
| secrets: inherit | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # This is for all internal employees' test runs. | ||
| # The goal is so that we can modify and change workflows without merging to main. | ||
| name: Internal Suite | ||
| on: | ||
| push: | ||
| branches: # this ignores tag pushes, and only looks at branches. | ||
| - '**' | ||
| release: | ||
| types: [prereleased, published] | ||
| jobs: | ||
| Automated-Tests: | ||
| name: Automated Tests | ||
| uses: ./.github/workflows/bedrock.yml | ||
| secrets: inherit | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this workflow now runs via
workflow_call, thegithub.eventpayload is for theworkflow_callevent, not the originalpull_request, sogithub.event.pull_request.numberwill be empty whenbedrock-fork-trigger.ymlcalls it. Withinputs.is_forkset, that makesGITHUB_BRANCHexpand to something likepull//head, which breaks theci_style.shfetch/diff logic for forked PRs (invalid refspec). To keep forked style checks working, pass the PR number as an explicit input from the caller or derive it fromgithub.refinstead ofgithub.event.pull_request.Useful? React with 👍 / 👎.