Track max transaction elapsed time across multiple transactions #2503
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
Update expensify_prod branch
When a command runs multiple transactions (e.g., peek then process), _totalTransactionElapsed was only storing the last transaction's time. This meant slow transactions in earlier phases were silently lost in timing logs. Use max() in both rollback and commit so the highest transaction time is preserved. Reset the counter at command boundaries (start of peekCommand) so it doesn't carry over between commands on the same shared db handle. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_totalTransactionElapsedwas only storing the last transaction's time, meaning the slowest transaction could be silently lost in timing logs.max()so the highest transaction time is preserved across all transactions within a single command.resetMaxTransactionElapsed()called at command boundaries (start ofpeekCommand) so the max doesn't carry over between commands on the same shared db handle.Test plan
🤖 Generated with Claude Code