Merged
Conversation
roryabraham
force-pushed
the
Rory-ValidateGitHubActionsAnyRepo
branch
from
0c7be80 to
863677e
Compare
rafecolton
approved these changes
May 7, 2025
Member
rafecolton
left a comment
rafecolton
left a comment
There was a problem hiding this comment.
LGTM, reviewed live with Rory. Tests are failing because it's referencing an action in main but I observed it working right before we removed that ref to the current branch.
roryabraham
changed the title
|
@rafecolton looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Member
|
Not actually an emergency, had to merge this with failing checks due to a chicken/egg problem describe above |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This updates this workflow so that it can be run from other repos (enabled by a org-level ruleset). This has been tested here: Expensify/App#61538
I am aware of an issue where this will not work to check for immutable actions in private repos for now.
Related Issues
related to https://github.com/Expensify/Expensify/issues/484931
Manual Tests
tested in Expensify/App#61538
Linked PRs
n/a