Skip to content

Use Github-Actions action lint config if one is not present in the repo#51

Merged
coleaeason merged 5 commits intomainfrom
cole/actionlint-default
Feb 6, 2026
Merged

Use Github-Actions action lint config if one is not present in the repo#51
coleaeason merged 5 commits intomainfrom
cole/actionlint-default

Conversation

@coleaeason
Copy link
Contributor

@AndrewGable I think this will let us use the actionlint config in this repo instead of each remote repo if a remote repo doesn't have it's own config.

Details

Related Issues

GH_LINK

Manual Tests

On main in a repo with no actionlint.yml:

../GitHub-Actions/scripts/actionlint.sh

Lint Github Actions via actionlint (https://github.com/rhysd/actionlint)
Found actionlint version 1.7.7 already installed
Linting workflows...

.github/workflows/pytest.yml:14:14: label "blacksmith-4vcpu-2404" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
   |
14 |     runs-on: blacksmith-4vcpu-2404
   |              ^~~~~~~~~~~~~~~~~~~~~
💥 Workflows did not pass actionlint :(

On this branch:

$ ../GitHub-Actions/scripts/actionlint.sh

Lint Github Actions via actionlint (https://github.com/rhysd/actionlint)
Found actionlint version 1.7.7 already installed
Linting workflows...

On this branch with a local actionlint:

$  ../GitHub-Actions/scripts/actionlint.sh

Lint Github Actions via actionlint (https://github.com/rhysd/actionlint)
Found actionlint version 1.7.7 already installed
Linting workflows...

🎉 Workflows passed actionlint!

Linked PRs

@coleaeason coleaeason self-assigned this Feb 6, 2026
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coleaeason
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

CLABotify added a commit to Expensify/CLA that referenced this pull request Feb 6, 2026
AndrewGable
AndrewGable previously approved these changes Feb 6, 2026
@coleaeason coleaeason merged commit cc61963 into main Feb 6, 2026
5 checks passed
@coleaeason coleaeason deleted the cole/actionlint-default branch February 6, 2026 21:02
@Skalakid
Copy link

@AndrewGable @coleaeason it looks like the switch to Blacksmith runners here inadvertently broke npm publish in the react-native-wallet repo. npm publish with provenance enabled strictly requires GitHub-hosted runners (ubuntu-latest) and automatically rejects self-hosted environments (which Blacksmith is classified as) with an E422 error

npm error code E422
npm error 422 Unprocessable Entity - PUT https://registry.npmjs.org/@expensify%2freact-native-wallet - Error verifying sigstore provenance bundle: Unsupported GitHub Actions runner environment: "self-hosted". Only "github-hosted" runners are supported when publishing with provenance.

@AndrewGable
Copy link
Contributor

Ah good to know, I will revert that change in the react-native-wallet repo.

@AndrewGable
Copy link
Contributor

@Skalakid - Should be fixed now 👍

@Skalakid
Copy link

@AndrewGable thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants