Merged
Conversation
Contributor
Author
|
@situchan The PR is ready. |
situchan
reviewed
Nov 7, 2025
lib/Device.ts
Outdated
| // https://docs.uaparser.dev/guides/how-to-detect-ios-26-using-javascript.html | ||
| if (browser.name === 'Mobile Safari' && browser.major === '26' && os.name === 'iOS' && os.version === '18.6') { | ||
| const [osMajor, osMinor] = (os.version ?? '').split('.'); | ||
| if (browser.name === 'Mobile Safari' && browser.major === '26' && os.name === 'iOS' && parseInt(osMajor, 10) >= 18 && parseInt(osMinor, 10) >= 6) { |
Contributor
Contributor
Author
|
I've just added a unit test |
situchan
reviewed
Nov 7, 2025
__tests__/Device-test.js
Outdated
| const UA_IOS_18 = 'Mozilla/5.0 (iPhone; CPU iPhone OS 18_6 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.6 Mobile/15E148 Safari/604.1'; | ||
| const UA_IOS_26_1 = 'Mozilla/5.0 (iPhone; CPU iPhone OS 18_6 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/26.0 Mobile/15E148 Safari/604.1'; | ||
| const UA_IOS_26_2 = 'Mozilla/5.0 (iPhone; CPU iPhone OS 18_7 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/26.0.1 Mobile/15E148 Safari/604.1'; | ||
| const UA_IOS_26_3 = 'Mozilla/5.0 (iPhone; CPU iPhone OS 18_10 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/26.1.2 Mobile/15E148 Safari/604.1'; |
Contributor
There was a problem hiding this comment.
Let's also add 18.7.2 version
situchan
reviewed
Nov 7, 2025
lib/Device.ts
Outdated
| // https://docs.uaparser.dev/guides/how-to-detect-ios-26-using-javascript.html | ||
| if (browser.name === 'Mobile Safari' && browser.major === '26' && os.name === 'iOS' && os.version === '18.6') { | ||
| const [osMajor, osMinor] = (os.version ?? '').split('.'); | ||
| if (browser.name === 'Mobile Safari' && browser.major === '26' && os.name === 'iOS' && parseInt(osMajor, 10) >= 18 && parseInt(osMinor, 10) >= 6) { |
Contributor
There was a problem hiding this comment.
parseInt(osMajor, 10) >= 18 && parseInt(osMinor, 10) >= 6
This condition is not correct. i.e. 19.1 -> also add to unit test
Contributor
Author
There was a problem hiding this comment.
You're right. I've just fixed it
situchan
approved these changes
Nov 10, 2025
Contributor
Author
|
@lakchote When you have a moment, could you please take a look? Thanks! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation of Change
The detection logic was entirely based on how-to-detect-ios-26-using-javascript, which has become outdated since
os.versioncan increase rapidly and exceed'18.6'.Therefore, this PR updates the logic to parse
os.versionand only proceed when both the major and minor versions are greater than'18.6'.Fixed Issues
$ Expensify/App#73240
PROPOSAL: Expensify/App#73240 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Precondition: user signed in with account A on main testing iOS 26 device and account B on secondary
Open staging.new.expensify.com
Navigate to chat with account B
Tap on the composer to open the virtual keyboard
Start typing on the secondary device where account B is logged in
Look at the typing indicator text below the composer.
Paste the following text into the composer to trigger the error message:
[] Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Aenean commodo ligula eget dolor. Aenean ma (creating task message with more than 100 characters)
Verify that the typing indicator and error messages should be fully visible and not overlapped by the site header when the composer is focused and virtual keyboard is open
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
The issue does not occur.
Android: mWeb Chrome
android.chrome.mp4
iOS: Native
The issue does not occur.
iOS: mWeb Safari
iOS 26:
ios.safari.26.mp4
iOS 18:
ios.safari.mp4
MacOS: Chrome / Safari
mac.safari.mp4
MacOS: Desktop
mac.desktop.mp4