Closed
Conversation
* remove dependency on "six" * remove last couple of "from __future__ import with_statement" * switch input.getargspec() to getfullargspec() * fix check for exception in utils.error() * setup: simplify paramiko req, update python version req * bump to version 1.20.0beta1 * ci: update test matrix: python 3.6 through 3.13 * ci: runners use ubuntu-24.04, containers use debian 11.x or 12.x * ci: update paramiko to latest patch releases: 2.8.10 / 2.7.12 / 2.6.6 * ci: update flake8 to 5.x * ci: ssh setup updates (mkdir -p, ecdsa key type) * ci: build docs with python-3.9 container * switch to nose-py3, fudge fork with use_2to3 removed * remove "rudolf" and thus nose "--with-color" arg * tests: don't fudge-patch output, use settings(show()) * tests: fix silly test_connect_does_not_prompt_password_when... * tests: remove obsolete __cmp__ from FakeFile
Member
Author
|
Reviewed the changes, look like they are all about modernizing. Nothing concerning stands out. |
Member
Author
|
Also tested with some basic saltfab operations and it works just fine |
Member
Author
|
The maintainer made some other changes, so going to close this and open a new PR once I've tested those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge upstream master into main in order to get ploxiln#83 merged