Fork fab-classic to support packaged saltfab#5
Merged
coleaeason merged 6 commits intomainfrom Jan 22, 2026
Merged
Conversation
As explained in the code, we are setting paramiko as the dependency instead of paramiko-ng with an optional replacement so that we can build our own version of fab-classic for installation via uv. uv, and all other third party package managers outside of PIP, pull the wheel metadata file during installation even with the --no-binary flag set, this means the REPLACE_PARAMIKO flag is not respected or used, so we need to build a package that has the static metadata set to paramiko instead of paramiko-ng.
This adds automated publishing and tagging of our forked version.
Author
|
@rafecolton please review when you have a moment |
rafecolton
approved these changes
Jan 21, 2026
Member
rafecolton
left a comment
rafecolton
left a comment
There was a problem hiding this comment.
LGTM. Please link to upstream issue once created 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rafecolton please review. This creates a slight fork from main of fab-classic so that we can publish a package to pyx.dev that has paramiko as the requirement in the wheel file. As discussed in slack, only
pipsupports thePARAMIKO_REPLACEos env variable available to try to set the metadata at install time. All other third party package managers (uv, pipx, poetry, etc) all pull the wheel's metadata if it's available instead of compiling the source package.This PR allows us to implement ploxiln#98 for our own usage.
I tried to keep this change as minimal as possible:
For tests, i configured the working branch of saltfab to use the published version in pyx, and it works great.