Fix: Android release build issue due to "unused" children variable

[war-in]

Details

MarkdownTextInputDecoratorShadowNode.cpp has layout method which first check if there is only one child returned from getChildren

const auto &children = getChildren();
  react_native_assert(
      children.size() == 1 &&
      "MarkdownTextInputDecoratorView didn't receive exactly one child");

and then gets the children again to extract the child

auto child = std::static_pointer_cast<const YogaLayoutableShadowNode>(getChildren()[0]);

While I'm migrating Expensify/App to React Native 0.81 I stepped upon this error, which caused adhoc build to crash

[14:24:49]: ▸ C/C++: /home/runner/work/App/App/node_modules/@expensify/react-native-live-markdown/android/src/main/new_arch/react/renderer/components/RNLiveMarkdownSpec/MarkdownTextInputDecoratorShadowNode.cpp:164:15: error: unused variable 'children' [-Werror,-Wunused-variable]
[14:24:49]: ▸ C/C++:   164 |   const auto &children = getChildren();
[14:24:49]: ▸ C/C++:       |               ^~~~~~~~
[14:24:49]: ▸ C/C++: 1 error generated.

Removing the second getChildren call and replacing it with the children variable fixed the issue

Related Issues

n/a

Manual Tests

Running the release build of the example app would be the best but I got Connect timed out from sonatype 🤷
I'll bump the live-markdown to this commit in E/App and link the working adhoc as proof
Adhoc build: Expensify/App#69535 (comment)

Linked PRs

Expensify/App#69535

[os-botify]

🚀 Published to npm in 0.1.306 🎉