Update example project #305
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from previous example app
Non-link installs were taking too long to iterate with. This approach makes installs faster. Need to also run react-native as linked with the library's specific copy -- otherwise library events do not work properly. yikes. Also had to reinstall pods after symlink fix
...to reduce errors in example projects. (VS Code will only use a tsconfig at project root, not nested within example projects, consider if we want to keep this)
TODO: - ios deployment target setting matching app - document disabling user sandboxing?
Clean up code while fixing issue with mimetype being undefined on iOS when app is first started with no share
…ng here, might be related
Update share extension's iOS deployment target to match react-native's
Url schemes, RN-specific data for share extension
Added an additional fix for "startsWith" which may error if mimeType is undefined This may not be fully functional yet, based on experience with copying the prior example app UI for the basic app. Would still need to test it out more. But sharing a photo to the main app worked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
This PR replaces the old example app with two new example apps: one to show "basic" share, with both Android and the default, non-customizable iOS share, and "custom", which demos creating a custom react-native UI in the share extension.
These example projects have been created using latest react-native so that it's easier to test changes to the library.
Note:
Additional changes
IOS_DEBUGGING.md, that should help empower developers to track down any issues they encountering in the share extensiona. react-native must be symlinked so that the app's copy and the library's copy are the same, or events won't work
a. fixed an issue with NSError that caused Xcode to complain
b. Made the code to store data on UserDefaults more consistent across code paths (updated to match here).
c. Fixed the issue that text sent in the share extension UI in the "basic" case was not sent, and so the demo code couldn't show extraData
Additional notes: