Make it compatible with cjs style of importing THREE#39
Open
Alchemist0823 wants to merge 1 commit intoExperience-Monks:masterfrom
Open
Make it compatible with cjs style of importing THREE#39Alchemist0823 wants to merge 1 commit intoExperience-Monks:masterfrom
Alchemist0823 wants to merge 1 commit intoExperience-Monks:masterfrom
Conversation
Because in my typescript project. three.js was included in a module. Calling THREE.BufferGeometry directly doesn't work.
Open
|
What's |
Author
|
HI @hypervillain, I think it's the syntax in some module system i don't know. I copied this from the most popular threejs libraries. this is the way they use to include the library to make it compatible both on nodejs module import and directly include three.js. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because in my typescript project. three.js was included in a module. Calling THREE.BufferGeometry directly doesn't work.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Did you test your solution?
Problem Description
Solution Description
Side Effects, Risks, Impact
Aditional comments: