Conversation
- updated alignment type - added polytope, vertex and edge types
- alignment moved from alignment_t to edge_aligned_t - added face_t
adampep
added
enhancement
|
Hi! I think these comments will be it for me. As I wrote previously on Zulip, I would generally like the enforcement of I did find it hard to keep track of all the types when doing the review, and I think the extra helper types that just wrap an allocatable to increase that issue quite considerably. I would therefore be in favour of enforcing some convention for those, as currently defined in at topic on Zulip. But I don't think this should prevent the merge atm, we can do that later. I think we will also need some kind of "developer guide" discussing some of the questions that pop up. Maybe extended module level docstrings similar to that I added for the alignment. I honestly think things might become clear as the _topology and _mesh objects actually become used. So we can do that in a alter PR as well. |
Co-authored-by: Timofey Mukha <timofeymukha@users.noreply.github.com>
- added object ownership, mapping and sharing types - added element, point and topology lists types - added initial files for testing
- deferred methods bnd and gsid removed from polytope_t - added select type to element_t methods fct_bnd, fct_gsid, rdg_gsid and pek_gsid
3 participants
Starting a discussion regarding code structure