Multiphase over integration#2217
Open
gloopydoop wants to merge 4 commits intotuan/case/lid-multiphasefrom
Open
Multiphase over integration#2217gloopydoop wants to merge 4 commits intotuan/case/lid-multiphasefrom
gloopydoop wants to merge 4 commits intotuan/case/lid-multiphasefrom
Conversation
gloopydoop
commented
Dec 3, 2025
| "numerics": { | ||
| "time_order": 3, | ||
| "polynomial_order": 7, | ||
| "dealias": true |
Collaborator
Author
There was a problem hiding this comment.
perhaps it makes more sense to place it here in the JSON
tuananhdao
approved these changes
Dec 7, 2025
Collaborator
|
why is it slower by 30 times? I would probably expect it's 10 times when assenble the total forcing term, and approximately the same time for the pressure and velocity equation (so in total much smaller than 30 times). |
Collaborator
|
I am wondering in this regard whether implementing some type of 2/3 rule instead could be beneficial, so that one does not need to dealias many individual terms...? Or is there a drawback on doing that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally a commit to multiphase!
In this PR I add a way of performing over integration (dealiasing) on the term
If one considers the test function too, this is 4 polynomials multiplied together, so it's not a 3/2 rules, it's a 4/2=2 rule.
You should be able to enable it with
"dealias_normal": trueunderscalar.There's also a little profiler wrapping each computations, I'm seeing (from small tests)