Open
Conversation
Co-authored-by: Shiyu Du <115027341+Shiyu-Sandy-Du@users.noreply.github.com>
…; add a new interface to let scalar scheme to access eddy diffusivity field calculated from sgs models
Align with the updated way of doing polymorphic objects. PR #2313 Introduce a factory for scalar schemes to enhance the management of scalar transport equations. Update the scalar manager to utilize the new wrapper type for better encapsulation and flexibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add a new SGS model based on temperature and TKE solved by two scalar equations with some input from me, @tuananhdao and @linneahuusko. The validation is done by the following plots from a shear-convection ABL simulation
