Merged
Conversation
timfelle
requested changes
Feb 18, 2026
Collaborator
timfelle
left a comment
timfelle
left a comment
There was a problem hiding this comment.
Great work!
There are a few things to look over.
Co-authored-by: Tim Felle Olsen <timfelle@hotmail.com>
Co-authored-by: Tim Felle Olsen <timfelle@hotmail.com>
Co-authored-by: Tim Felle Olsen <timfelle@hotmail.com>
Co-authored-by: Tim Felle Olsen <timfelle@hotmail.com>
vbaconnet
approved these changes
Feb 18, 2026
6 tasks
Collaborator
Author
|
Let me know what else I should change. |
timfelle
approved these changes
Feb 20, 2026
Co-authored-by: Tim Felle Olsen <timfelle@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added vector list with the same characteristics as field_list_t. @timfelle , if you already had this somewhere, then of course ignore :).
I think it would be nice to add names to the vectors. The particular use-case I was thinking about was to further extend #2325 once it is merged.
I would like that functionality to accept a list of keys to read, and since
fld_file_data_tusesvector_t, it would be nice if one could search a vector by name. This would also help to have a unique interface with hdf5, I believe.I do not like that these searches need to always traverse the list. But I suppose that having hashtables with these types is overkill, considering that we never have crazy many entries.