Skip to content

Conversation

@9sneha-n
Copy link
Contributor

@9sneha-n 9sneha-n commented Feb 23, 2025

📌 References

📝 Implementation

  1. Apply pagination on all survey lists
  2. Remove non-paginaton code
  3. Sort paginated list
  4. Search paginated lists
  5. Filter paginated lists

📹 Screenshots/Screen capture

Screenshot 2025-03-06 at 1 16 27 PM Screenshot 2025-03-06 at 1 17 17 PM Screenshot 2025-03-06 at 1 17 35 PM

🔥 Notes to the tester

@ifoche
Copy link
Member

ifoche commented Mar 6, 2025

@9sneha-n 9sneha-n changed the title Feat/paginated surveys Paginated Survey Lists Mar 6, 2025
@9sneha-n 9sneha-n marked this pull request as ready for review March 6, 2025 19:56
@MiquelAdell
Copy link
Contributor

@9sneha-n could you merge development into this branch to solve the conflicts? thank you!

@9sneha-n
Copy link
Contributor Author

@MiquelAdell Merge done.

Copy link
Contributor

@MatiasArriola MatiasArriola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @9sneha-n! Great work overall, this was a big change! I left some comments for improvements. Let me know if if you have any question or if you'd like to discuss anything further.

Another idea to consider: instead of passing all the paging and sorting state setters/getters down from SurveyListPage -> SurveyList -> PaginatedSurveyListTable , you could use a Context and access the sorting and paging state via custom hooks within the components. This could help simplify prop drilling. I'm not sure if this change is necessary for approval, but I wanted to suggest it as a possible improvement. It's up to you to decide if it's valuable and whether we have time to implement it, as it might not be a straightforward change.

Thanks again!

@9sneha-n
Copy link
Contributor Author

TableCell

Good idea @MatiasArriola . @MiquelAdell the proposed design change is good to have for improved code. Based on our discussion in follow-up, wanted to check if we have time for this enhancement at this point in time? If not, we can add a task for "Create survey list page details context" in the backlog.

@9sneha-n
Copy link
Contributor Author

@MatiasArriola Addressed comments, ready for re-review.

@9sneha-n 9sneha-n requested a review from MatiasArriola March 13, 2025 08:43
Copy link
Contributor

@MatiasArriola MatiasArriola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks @9sneha-n !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants