Add functions to decode vast and vmap using xmlTokenizer#5
Merged
Lunkers merged 17 commits intoEyevinn:mainfrom Jun 23, 2025
Merged
Add functions to decode vast and vmap using xmlTokenizer#5Lunkers merged 17 commits intoEyevinn:mainfrom
Lunkers merged 17 commits intoEyevinn:mainfrom
Conversation
(Needs library update to handle single quote xml attributes)
Lunkers
approved these changes
Jun 23, 2025
Collaborator
Lunkers
left a comment
There was a problem hiding this comment.
While I personally feel like some variable names aren't the most intuitive, It is standard practice for golang; that nitpick aside, this looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could probably be faster, but this will handle things coming in as CDATA or just straight xml encoded