Skip to content

Add functions to decode vast and vmap using xmlTokenizer#5

Merged
Lunkers merged 17 commits intoEyevinn:mainfrom
CarlLindqvist:performant-decode
Jun 23, 2025
Merged

Add functions to decode vast and vmap using xmlTokenizer#5
Lunkers merged 17 commits intoEyevinn:mainfrom
CarlLindqvist:performant-decode

Conversation

@CarlLindqvist
Copy link
Contributor

@CarlLindqvist CarlLindqvist commented Jun 19, 2025

Could probably be faster, but this will handle things coming in as CDATA or just straight xml encoded

goos: darwin
goarch: arm64
pkg: github.com/Eyevinn/VMAP/vmap
cpu: Apple M2 Pro
BenchmarkUnmarshal-12       	    1389	    862222 ns/op	  280116 B/op	    6786 allocs/op
BenchmarkFasterDecode-12    	    7166	    162484 ns/op	   60466 B/op	     868 allocs/op
PASS
ok  	github.com/Eyevinn/VMAP/vmap	3.654s

Copy link
Collaborator

@Lunkers Lunkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I personally feel like some variable names aren't the most intuitive, It is standard practice for golang; that nitpick aside, this looks good to me!

@Lunkers Lunkers merged commit 9478a73 into Eyevinn:main Jun 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants